refactor: rename email cloud functions to purpose-driven names#42
Closed
pyramation wants to merge 3 commits into
Closed
refactor: rename email cloud functions to purpose-driven names#42pyramation wants to merge 3 commits into
pyramation wants to merge 3 commits into
Conversation
- simple-email → send-email (email:send_email) - send-email-link → send-verification-link (email:send_verification_link) Renames function directories, handler.json names, env vars, k8s manifests, skaffold profiles, tests, scripts, and documentation. Part of constructive-planning#837
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
The renamed function packages (@constructive-io/send-email-fn, @constructive-io/send-verification-link-fn) are workspace packages generated from handler.json, not published to npm. Use workspace:^ protocol to resolve them correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the email cloud function identifiers to purpose-driven names, establishing the
scope:fnnaming convention:simple-emailsend-emailemail:send_emailsend-email-linksend-verification-linkemail:send_verification_linkChanges across 49 files:
functions/simple-email/→functions/send-email/,functions/send-email-link/→functions/send-verification-link/namefields to match new directory namesSIMPLE_EMAIL_DRY_RUN→SEND_EMAIL_DRY_RUN,SEND_EMAIL_LINK_DRY_RUN→SEND_VERIFICATION_LINK_DRY_RUN)@constructive-io/simple-email-fn→@constructive-io/send-email-fn, etc.)Part of a coordinated rename across 4 repos — see constructive-planning#837.
Review & Testing Checklist for Human
pnpm generatestill produces correct workspace packages with the new function names (thegenerated/dir is gitignored so needs local validation)pnpm buildsucceeds after generationmake skaffold-devand confirm both functions start and process jobsNotes
skaffold.yamlis auto-generated byscripts/generate.ts— the renames here should be validated by runningpnpm generatewhich will overwrite with freshly generated content matching the new handler.json namespnpm-lock.yamlwill need regeneration after the package.json dependency renames (pnpm install --no-frozen-lockfile)Link to Devin session: https://app.devin.ai/sessions/0bebbaeb3b374fd28f5ed051354b3b94
Requested by: @pyramation