Skip to content

fix(tui): keep focus sweep visible on borders - #1295

Merged
edwin-zvs merged 1 commit into
mainfrom
fix-tui-visible-border-animation
Aug 20, 2026
Merged

fix(tui): keep focus sweep visible on borders#1295
edwin-zvs merged 1 commit into
mainfrom
fix-tui-visible-border-animation

Conversation

@edwin-zvs

Copy link
Copy Markdown
Contributor

Summary

  • compose the moving focus sweep as a border-glyph toggle, erasing cells where a pane or Playbook border is already visible
  • retain the bright drawn segment on hidden side and bottom edges without changing animation timing, geometry, or border visibility semantics
  • add phase-frozen frame regressions for top-only chrome, full Playbook or /border frames, hidden edges, corners, and title preservation
  • update the focused UX spec to record the visible-versus-hidden composition rule

Follow-up to #1278.

Verification

  • cargo test -p construct-cli focus_border -- --nocapture (7 passed)
  • cargo build (passed)
  • git diff --check (passed)
  • cargo fmt --all -- --check reports a pre-existing repository-wide rustfmt delta across untouched crates; no formatting changes were applied outside this focused diff

Visual verification

The TestBackend regressions freeze the 200 ms animation at an exact phase and render real Ratatui Block frames before applying the sweep. They verify that the same moving cells are blank over an always-visible top rule or full Playbook or /border frame, and bright line glyphs over hidden edges. A trustworthy before/after VHS pair would require the second pre-change worktree mandated by AGENTS.md, while this task explicitly disallows creating another worktree, so the exact frame assertions are the more deterministic artifact here.

@edwin-zvs
edwin-zvs force-pushed the fix-tui-visible-border-animation branch from 25aa258 to b80cba9 Compare August 20, 2026 02:40
@edwin-zvs
edwin-zvs merged commit 0f5dcc8 into main Aug 20, 2026
1 of 3 checks passed
@edwin-zvs
edwin-zvs deleted the fix-tui-visible-border-animation branch August 20, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant