Skip to content

Fix WebUI Playbook editor font scale #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwin-zvs merged 1 commit into from
Aug 20, 2026
Merged

Fix WebUI Playbook editor font scale #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/daemon/assets/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3194,7 +3194,7 @@
border: 0;
padding: 12px 14px;
font-family: "SFMono-Regular", ui-monospace, "JetBrains Mono", Menlo, Consolas, monospace;
font-size: 14px;
font-size: 13px;
line-height: 1.6;
tab-size: 2;
white-space: pre-wrap;
Expand Down
15 changes: 15 additions & 0 deletions crates/e2e/tests/playbook_view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ async fn web_playbook_view_full_parity() {
}, async () => {
setSession("s-prog", "shell");
await switchCurrentViewMode("playbook");
const editorStyle = getComputedStyle(playbookInputEl);
const barStyle = getComputedStyle(playbookWrapEl.querySelector(".playbook-bar"));
return {
wrapVisible: !playbookWrapEl.hidden,
transcriptHidden: transcriptEl.hidden,
Expand All @@ -103,6 +105,9 @@ async fn web_playbook_view_full_parity() {
playbookPressed: viewModePlaybookBtn.getAttribute("aria-pressed"),
mode: state.mode,
mounted: state.playbook.mountedId,
editorFontSize: editorStyle.fontSize,
surroundingFontSize: barStyle.fontSize,
editorFontFamily: editorStyle.fontFamily,
};
})
"###,
Expand All @@ -118,6 +123,16 @@ async fn web_playbook_view_full_parity() {
assert_eq!(enter["playbookPressed"], "true", "{enter:?}");
assert_eq!(enter["mode"], "playbook", "{enter:?}");
assert_eq!(enter["mounted"], "s-prog", "{enter:?}");
assert_eq!(
enter["editorFontSize"], enter["surroundingFontSize"],
"Playbook body text should match the surrounding WebUI scale: {enter:?}"
);
assert!(
enter["editorFontFamily"]
.as_str()
.is_some_and(|family| family.contains("monospace")),
"Playbook body text should retain a monospace editor stack: {enter:?}"
);

// --- 2a. Inline code paints without delimiters; Backspace at its right
// edge reveals the opening delimiter and editable text. ---------
Expand Down
Loading