Fix TUI modal input precedence over Playbook - #1292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The layout snapshot stored only one modal rectangle. Keyboard routing checked the focused Playbook before Remote Control, mouse routing called the Playbook editor before consulting the visible dialog, and generic click handling inferred rectangle ownership from whether a Playbook happened to remain mounted. A Remote Control dialog could therefore paint above the Playbook while input still mutated the editor underneath.
Testing
The repository e2e package is named construct-e2e; timing and network dependent tests remain ignored by their existing annotations.