update flink statement warnings UI based on new response structure by noeldevelops · Pull Request #3254 · confluentinc/vscode

Noel Cothren (noeldevelops) · 2026-02-03T21:59:28Z

Summary of Changes

Display statement warnings that are returned with new API
Preserves legacy format for statement warnings inside of Details, but prefers new warnings structure when available
Rearranges the way error, info, warnings details are surfaced in the Statement Results Viewer header section & simplifies the HTML/CSS for this element
Closes Integrate new Statement Warnings feature #3067

Click-testing instructions

Changes are visible in the VS Code Flink Statement Results viewer when there are Statement Details, Errors, or Warnings. The new API is under a feature flag, so requires internal access to our Staging environment where the flag is enabled. There are detailed testing scenarios for the internal team in shared docs.

Run a Flink statement that you know will produce a warning or error to see the new UI elements
OR Stop a statement that is running to see the Info message "This statement was stopped manually."
OR, mock some warnings: in flink-statement-results.ts file, set this.hasWarnings to true & add an array of mocks e.g.

 this.formattedWarnings = this.derive(() => {
      const mockWarnings = [ {
          severity: "LOW",
          message: "This is a low severity warning for testing purposes.",
          reason: "LOW_SEVERITY_TEST",
          createdAt: "2025-11-14T15:00:00Z",
          isCritical: false,
        }, ...

Optional: Any additional details or context that should be provided?

Feature flag for the new warnings API is not enabled in production yet; we'll stay backward compatible for the foreseeable future
⚠️ Note: not all these boxes will be shown at once -- normally just 1 or two items returned

Light

Dark

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests

Added new
Updated existing
Deleted existing

Release notes

Does anything in this PR need to be mentioned in the user-facing CHANGELOG?

Copilot

Pull request overview

Updates the Flink Statement Results webview to surface statement warnings using the new structured warnings field from the getSqlv1Statement response, while remaining backward compatible with legacy [Warning] text embedded in status.detail.

Changes:

Add warning parsing utilities to prefer structured API warnings and fall back to legacy [Warning] parsing.
Extend statement models/results manager/webview view model to pass warnings through to the results viewer.
Refactor results viewer “details/warnings” header UI into a unified list with updated HTML/CSS rendering.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/webview/flink-statement-results.ts	Builds a unified `detailItems` list combining error/info detail text with structured/legacy warnings.
src/webview/flink-statement-results.html	Reworks the header details UI to render multiple detail items with severity styling.
src/models/flinkStatement.ts	Adds a `warnings` getter that extracts structured warnings or parses legacy detail warnings.
src/flinkSql/warningParser.ts	New helper module to parse legacy warnings, prefer structured warnings, and strip `[Warning]` blocks from detail.
src/flinkSql/warningParser.test.ts	Unit tests for warning parsing/extraction/stripping behavior.
src/flinkSql/flinkStatementResultsManager.ts	Includes statement warnings in the data returned to the webview.
src/flinkSql/flinkStatementResultsManager.test.ts	Updates expected statement meta to include `warnings`.

You can also share your feedback on Copilot code review. Take the survey.

Noel Cothren (noeldevelops)

Claude wrote & posted this :)
"Self-review: found a few items to address."

sonarqube-confluent · 2026-03-05T15:34:36Z

Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Clarifies that the type assertion should be removed once the OpenAPI spec includes the warnings field on statement status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove hasWarnings, hasCriticalWarnings, and formattedWarnings signals that were not referenced in the template or elsewhere. Inline the formatting logic directly into the detailItems derivation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge identical .detail-item.error/.detail-item.critical and .detail-severity.error/.detail-severity.critical rules into combined selectors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

detailText was only consumed by detailItems, making it an unnecessary intermediate signal. Inline the logic to simplify the reactive graph. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ate format - Remove .replace(/\n/g, "<br>") since data-text + pre-wrap handles newlines - Extract duplicated legacy warning regex into shared LEGACY_WARNING_PATTERN - Use .toLocaleString() instead of String() for warning timestamps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Dave Shoup (shouples)

LGTM and works well from what I was able to clicktest in our various environments, just one minor question but shouldn't block merging

Dave Shoup (shouples) · 2026-04-14T18:42:23Z

+/** API warning shape from the new structured warnings field */
+export interface StatementWarning {
+  readonly severity: string;
+  readonly created_at: Date | null;
+  readonly reason: string;
+  readonly message: string;
+}


Any reason we don't use SqlV1StatementWarning directly? Looks like the only difference is some of these values are set as readonly but I don't think any call points try to mutate these properties after we get the response back

ah good catch. I'm updating now to use the client type. created_at is the only thing that needs a little fix, incoming...

update date null handling to work

sonarqube-confluent · 2026-04-14T21:04:56Z

Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Dave Shoup (shouples)

👏

airlock-confluentinc Bot force-pushed the ncothren/3067-statement-warnings branch from 741864d to 99f59ae Compare February 25, 2026 17:54

Noel Cothren (noeldevelops) changed the title ~~[WIP] #3067 statement warnings api~~ #3067 statement warnings api Mar 3, 2026

Noel Cothren (noeldevelops) changed the title ~~#3067 statement warnings api~~ [#3067] update statement warnings UI based on new response structure Mar 3, 2026

Noel Cothren (noeldevelops) changed the title ~~[#3067] update statement warnings UI based on new response structure~~ update flink statement warnings UI based on new response structure Mar 3, 2026

Copilot AI review requested due to automatic review settings March 3, 2026 20:34

Noel Cothren (noeldevelops) review requested due to automatic review settings March 3, 2026 20:34

Noel Cothren (noeldevelops) mentioned this pull request Mar 3, 2026

new flink sql openapi spec + apigen changes #3310

Merged

Copilot AI review requested due to automatic review settings March 3, 2026 21:54

airlock-confluentinc Bot force-pushed the ncothren/3067-statement-warnings branch from 4660052 to 22ba7e8 Compare March 3, 2026 21:54

Noel Cothren (noeldevelops) review requested due to automatic review settings March 3, 2026 21:54

Copilot AI review requested due to automatic review settings March 3, 2026 22:09

Noel Cothren (noeldevelops) review requested due to automatic review settings March 3, 2026 22:09

Copilot AI review requested due to automatic review settings March 3, 2026 22:15

Noel Cothren (noeldevelops) review requested due to automatic review settings March 3, 2026 22:15

Copilot AI review requested due to automatic review settings March 3, 2026 23:03

Noel Cothren (noeldevelops) review requested due to automatic review settings March 3, 2026 23:03

Noel Cothren (noeldevelops) marked this pull request as ready for review March 3, 2026 23:08

Noel Cothren (noeldevelops) requested a review from a team as a code owner March 3, 2026 23:08

Copilot AI review requested due to automatic review settings March 3, 2026 23:08

Copilot started reviewing on behalf of Noel Cothren (noeldevelops) March 3, 2026 23:09 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread src/flinkSql/warningParser.ts Outdated

Comment thread src/webview/flink-statement-results.html

Comment thread src/webview/flink-statement-results.html Outdated

Noel Cothren (noeldevelops) marked this pull request as draft March 5, 2026 14:50

Noel Cothren (noeldevelops) commented Mar 5, 2026

View reviewed changes

Comment thread src/webview/flink-statement-results.ts Outdated

Comment thread src/flinkSql/warningParser.ts Outdated

Comment thread src/webview/flink-statement-results.ts Outdated

Noel Cothren (noeldevelops) added 6 commits April 13, 2026 09:02

initial warning api support

f2c78e0

combine all details, improve css

471a283

no badge

262e4b9

simplify, reorder infos

8af309d

more css tweaks

ed9bd55

strip warnings from detail if they are provided by API

7213056

Noel Cothren (noeldevelops) and others added 16 commits April 13, 2026 09:03

more obvious severity, reason, timestamp

6a28fc4

make errors match new warnings

251f2dc

DRYer model for messages

7183b9d

prettier format fix

abcb2aa

add TODO for type assertion on status warnings

479db11

Clarifies that the type assertion should be removed once the OpenAPI spec includes the warnings field on statement status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

remove unused warning signals

d4d30ca

Remove hasWarnings, hasCriticalWarnings, and formattedWarnings signals that were not referenced in the template or elsewhere. Inline the formatting logic directly into the detailItems derivation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

combine duplicate CSS selectors for error and critical severity

bc0aec8

Merge identical .detail-item.error/.detail-item.critical and .detail-severity.error/.detail-severity.critical rules into combined selectors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

inline detailText signal into detailItems

c284b1a

detailText was only consumed by detailItems, making it an unnecessary intermediate signal. Inline the logic to simplify the reactive graph. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

remove text shrink

6895c2b

updates to use api types

a7df66c

severity is a generic string

1718144

type fix, handle as if string | date

2498d21

make StatementWarning properties readonly for API type compatibility

e90d78a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

use data-text instead of data-html for detail messages to prevent inj…

42f7f22

…ection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

move data-testid to detail-message element for e2e test compatibility

2be41ff

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

airlock-confluentinc Bot force-pushed the ncothren/3067-statement-warnings branch from ab708d6 to 83b6e36 Compare April 13, 2026 15:04

Noel Cothren (noeldevelops) added this to the Release 2.3 milestone Apr 13, 2026

update changelog

19550e5

Noel Cothren (noeldevelops) marked this pull request as ready for review April 13, 2026 15:18

Dave Shoup (shouples) self-assigned this Apr 13, 2026

Dave Shoup (shouples) previously approved these changes Apr 14, 2026

View reviewed changes

replace custom interface w/ generated type from API client

f050c09

update date null handling to work

airlock-confluentinc Bot dismissed Dave Shoup (shouples)’s stale review via f050c09 April 14, 2026 20:52

Noel Cothren (noeldevelops) requested a review from Dave Shoup (shouples) April 14, 2026 21:00

Dave Shoup (shouples) approved these changes Apr 14, 2026

View reviewed changes

Noel Cothren (noeldevelops) merged commit 98a80b8 into main Apr 15, 2026
13 of 14 checks passed

Noel Cothren (noeldevelops) deleted the ncothren/3067-statement-warnings branch April 15, 2026 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update flink statement warnings UI based on new response structure#3254

update flink statement warnings UI based on new response structure#3254
Noel Cothren (noeldevelops) merged 24 commits intomainfrom
ncothren/3067-statement-warnings

Noel Cothren (noeldevelops) commented Feb 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Noel Cothren (noeldevelops) left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqube-confluent Bot commented Mar 5, 2026

Uh oh!

Dave Shoup (shouples) left a comment

Uh oh!

Dave Shoup (shouples) Apr 14, 2026

Uh oh!

Noel Cothren (noeldevelops) Apr 14, 2026

Uh oh!

sonarqube-confluent Bot commented Apr 14, 2026

Uh oh!

Dave Shoup (shouples) left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Noel Cothren (noeldevelops) commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Click-testing instructions

Optional: Any additional details or context that should be provided?

Pull request checklist

Tests

Release notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Noel Cothren (noeldevelops) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqube-confluent Bot commented Mar 5, 2026

Quality Gate failed

Uh oh!

Dave Shoup (shouples) left a comment

Choose a reason for hiding this comment

Uh oh!

Dave Shoup (shouples) Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Noel Cothren (noeldevelops) Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqube-confluent Bot commented Apr 14, 2026

Quality Gate failed

Uh oh!

Dave Shoup (shouples) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Noel Cothren (noeldevelops) commented Feb 3, 2026 •

edited

Loading

Noel Cothren (noeldevelops) left a comment •

edited

Loading