[KIP-932] : Add more tests for close and destroy 5/N#2285
Merged
Kaushik Raina (k-raina) merged 3 commits intoJun 24, 2026
Merged
[KIP-932] : Add more tests for close and destroy 5/N#2285Kaushik Raina (k-raina) merged 3 commits into
Kaushik Raina (k-raina) merged 3 commits into
Conversation
Kaushik Raina (k-raina)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
Bot
force-pushed
the
dev_kip-932_queues-for-kafka_add_tests_5_of_N
branch
from
6ff80ff to
745bad2
Compare
Kaushik Raina (k-raina)
changed the title
airlock-confluentinc
Bot
force-pushed
the
dev_kip-932_queues-for-kafka_add_tests_5_of_N
branch
from
745bad2 to
013ac74
Compare
Pratyush Ranjan (PratRanj07)
requested changes
Jun 24, 2026
Comment on lines
+156
to
+166
| def test_callback_reentrancy_guard_covers_all_methods(kafka_cluster): | ||
| """Any consumer method called from inside the ack-commit callback is | ||
| rejected with IllegalStateException and leaves the consumer usable. The | ||
| reentrancy guard reports _STATE, which surfaces as IllegalStateException | ||
| (not a KafkaException). Extends test_callback_reentrancy_guard (which only | ||
| checks commit_async + set_callback) to poll, the subscribe family, | ||
| commit_sync, and acknowledge. | ||
|
|
||
| close() is left out on purpose: calling it from the callback currently | ||
| bricks the consumer even though the call is rejected (a known bug, tracked | ||
| separately), which would wreck the rest of the test. |
Contributor
There was a problem hiding this comment.
Close also has this librdkafka entrancy check. What do you mean by this?
Kaushik Raina (k-raina)
requested review from
Pratyush Ranjan (PratRanj07)
and removed request for
Copilot
|
Pratyush Ranjan (PratRanj07)
approved these changes
Jun 24, 2026
Pratyush Ranjan (PratRanj07)
left a comment
Pratyush Ranjan (PratRanj07)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks Kaushik Raina (@k-raina)
Kaushik Raina (k-raina)
deleted the
dev_kip-932_queues-for-kafka_add_tests_5_of_N
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add more tests for close and destroy