[KIP-932] Add share consumer workflow tests 4/N#2284
Merged
Kaushik Raina (k-raina) merged 3 commits intoJun 24, 2026
Merged
Conversation
Kaushik Raina (k-raina)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
Bot
force-pushed
the
dev_kip-932_queues-for-kafka_add_tests_poll_4_of_N
branch
from
3713734 to
68eb6fd
Compare
| try: | ||
| set_group_config(kafka_cluster, group_id, 'share.isolation.level', 'read_committed') | ||
| except KafkaException as e: | ||
| pytest.skip(f'cannot set share.isolation.level on group: {e}') |
Contributor
There was a problem hiding this comment.
One thing the brokers above 4.2.0 allow this and I think all the share consumer tests should run after that only! So in that case I dont think we need these pytest.skips?
Kaushik Raina (k-raina)
requested review from
Pratyush Ranjan (PratRanj07)
and removed request for
Copilot
|
Pratyush Ranjan (PratRanj07)
approved these changes
Jun 24, 2026
Pratyush Ranjan (PratRanj07)
left a comment
Pratyush Ranjan (PratRanj07)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks Kaushik Raina (@k-raina)
Kaushik Raina (k-raina)
deleted the
dev_kip-932_queues-for-kafka_add_tests_poll_4_of_N
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary