Skip to content

[KIP-932] Add tests for user callbacks in share consumer 2/N#2280

Open
Kaushik Raina (k-raina) wants to merge 3 commits into
masterfrom
dev_kip-932_queues-for-kafka_add_tests_user_callback_2_of_N
Open

[KIP-932] Add tests for user callbacks in share consumer 2/N#2280
Kaushik Raina (k-raina) wants to merge 3 commits into
masterfrom
dev_kip-932_queues-for-kafka_add_tests_user_callback_2_of_N

Conversation

@k-raina

@k-raina Kaushik Raina (k-raina) commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Add 21 tests for ShareConsumer callbacks (error_cb, log_cb, oauth_cb, stats_cb, throttle_cb) across the unit and integration suites
  • Unit: error_cb dispatch + exception propagation through poll/commit_sync/commit_async/close; oauth_cb principal+extensions, token-refresh success & failure-recovery, malformed-return; log_cb drain on
    commit/close, record format, and always-on (non-debug) delivery; stats_cb / statistics.interval.ms=0 rejection edges.
  • Integration: assert share-specific log facility tags (SHAREFETCH/SHAREACK/SHARESESSION/SHAREHEARTBEAT) and the cleared throttle_time=0 throttle event.
  • Add a provision_client_quota fixture so throttle tests self-provision/tear-down quotas and run unattended in CI — replacing the manual SHARE_THROTTLE_QUOTA_CLIENT_ID env-var gating.
  • Document a real crash via 3 skipped tests: calling a ShareConsumer method from inside a generic callback SIGSEGVs (librdkafka's reentrancy guard covers only the ack-commit cb); cross-thread correctly raises _CONFLICT — un-skip and assert _STATE once the guard is extended.

@confluent-cla-assistant

Copy link
Copy Markdown

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@k-raina Kaushik Raina (k-raina) changed the title [KIP-932] Add tests for user callbacks in share consumer [KIP-932] Add tests for user callbacks in share consumer 2/N Jun 15, 2026
@sonarqube-confluent

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
1.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Base automatically changed from dev_kip-932_queues-for-kafka_fix-librdkafka-api-changes to dev_kip-932_queues-for-kafka June 17, 2026 05:26
Base automatically changed from dev_kip-932_queues-for-kafka to master June 23, 2026 08:53
@airlock-confluentinc airlock-confluentinc Bot force-pushed the dev_kip-932_queues-for-kafka_add_tests_user_callback_2_of_N branch from 2cf2461 to f6a8ee5 Compare June 24, 2026 07:03
Copilot AI review requested due to automatic review settings June 24, 2026 07:03
@k-raina Kaushik Raina (k-raina) removed the request for review from Copilot June 24, 2026 07:03
Copilot AI review requested due to automatic review settings June 24, 2026 09:11
@k-raina Kaushik Raina (k-raina) removed the request for review from Copilot June 24, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant