fix: align KafkaError stub keyword with runtime#2278
Open
wgu9 (wgu9) wants to merge 1 commit into
Open
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2243.
Changes
KafkaErrorstub initializer parameter fromcodetoerror, matching the C extension keyword accepted at runtime.error=is accepted andcode=raisesTypeError.Validation
MYPYPATH=src uvx --from mypy==1.18.2 mypy --python-version 3.11 -c $'from confluent_kafka import KafkaError\\nKafkaError(error=1)'\n-MYPYPATH=src uvx --from mypy==1.18.2 mypy --python-version 3.11 -c $'from confluent_kafka import KafkaError\\nKafkaError(code=1)'confirmscode=is rejected\n-python3 -m py_compile tests/test_kafka_error.py\n-uvx --from black black --check --diff tests/test_kafka_error.py\n-git diff --check\n\nNote: I could not runpytest tests/test_kafka_error.pylocally because this fresh checkout does not have the compiledconfluent_kafkaextension or pytest installed. The added pytest is intended for CI, where the package is built before test execution.