DGS-24388 - Update schema counts to match UI and billing#3374
Open
tmalik (tmalikconfluent) wants to merge 1 commit into
Open
DGS-24388 - Update schema counts to match UI and billing#3374tmalik (tmalikconfluent) wants to merge 1 commit into
tmalik (tmalikconfluent) wants to merge 1 commit into
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR updates Schema Registry cluster describe metrics handling so schema counts match UI/billing behavior for legacy LSRCs spanning multiple PSRCs.
Changes:
- Builds a raw Metrics API query with
time_agg=MAXandagg=SUMforschema_count. - Adds a raw metrics client helper for fields unsupported by the typed SDK.
- Updates test server behavior and golden output to validate the corrected schema count.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/schema-registry/command_cluster_describe.go |
Switches schema count metrics query to raw JSON with billing-aligned aggregation. |
pkg/ccloudv2/metrics.go |
Adds MetricsDatasetQueryRaw to post custom Metrics API request bodies. |
test/test-server/metrics_handlers.go |
Validates the schema count query shape and returns a multi-PSRC test value. |
test/fixtures/output/schema-registry/cluster/describe.golden |
Updates expected used/available schema counts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Steven Gagniere (sgagniere)
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Fix schema counts for schema registry to match UI and billing
Blast Radius
Schema registry schema counts could be broken in worst case.
References
https://confluentinc.atlassian.net/browse/DGS-24388
Test & Review
Added integration tests.
Manual testing:
Created a lsrc with schemas in host and a different psrc.
Before the change:
After the change:
