Skip to content

lisa/feat/bch-1310-suggestions-worker#419

Merged
gusfcarvalho merged 3 commits into
mainfrom
lisa/feat/bch-1310-suggestions-worker
Jun 15, 2026
Merged

lisa/feat/bch-1310-suggestions-worker#419
gusfcarvalho merged 3 commits into
mainfrom
lisa/feat/bch-1310-suggestions-worker

Conversation

@ccf-lisa

@ccf-lisa ccf-lisa Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

automated implementation by lisa.

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First-pass review of the dashboard suggestion worker (HEAD f6cbf4c). Solid, well-tested implementation — CI is green (build/vet/lint/unit/integration), and the prior pass-1 high River timeout finding is genuinely fixed: the worker now embeds river.WorkerDefaults + implements Timeout() and is registered via river.AddWorker rather than river.WorkFunc. Concurrency/finalization logic (cell-row locking, single run_started emission, race-free last-cell finalization, ByArgs idempotence — InsertMany honors UniqueOpts gracefully in River v0.30.1) all check out, including under the -race concurrent shuffled integration test.\n\nNo blockers. Findings inline are all non-blocking: one Low on terminal-write durability for a stuck-run edge case on the final attempt (no reaper), plus a stats-accounting question and two maintainability nits. Nothing here needs to gate merge.

Comment thread internal/service/worker/dashboard_suggestion_worker.go Outdated
Comment thread internal/service/worker/dashboard_suggestion_worker.go Outdated
Comment thread internal/service/worker/dashboard_suggestion_worker.go
Comment thread internal/service/worker/service.go Outdated
@gusfcarvalho gusfcarvalho enabled auto-merge (squash) June 15, 2026 15:53
@ccf-lisa

ccf-lisa Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

PR approved. Marking as ready for e2e.

@gusfcarvalho gusfcarvalho merged commit 0b916e5 into main Jun 15, 2026
4 checks passed
@gusfcarvalho gusfcarvalho deleted the lisa/feat/bch-1310-suggestions-worker branch June 15, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant