Skip to content

[cpyrt] Import the cppjit module when gThisModule is null #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronj0 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

[cpyrt] Import the cppjit module when gThisModule is null #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/cpyrt/API.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,15 @@ static bool Initialize() {
<< std::endl;
return false;
}
}

// force loading of the cppjit module
PyRun_SimpleString(const_cast<char*>("import cppjit"));
// Importing the extension module is what runs the cpyrt initialization
// that sets gThisModule.
if (!cpyrt::gThisModule) {

@vgvassilev vgvassilev Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open an issue tracking the progress of removing global state?

@guitargeek guitargeek Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please go ahead! Would be useful if the issue said which globals you have in mind (gThisModule, gPyTypeMap, gMainDict, the PyString globals? ..) and what problem they cause (subinterpreters, teardown, etc.), so it's actionable rather than a general cleanup item. Because in general, global "immortal" state is not an anti-pattern in CPython.

PyObject* cppjitmod = PyImport_ImportModule("cppjit");
if (!cppjitmod)
return false;
Py_DECREF(cppjitmod);
}

if (!gMainDict) {
Expand Down
Loading