Skip to content

plane_to_rhino bug: add missing y-axis vector argument #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jwwang0-0 wants to merge 1 commit into from
Closed

plane_to_rhino bug: add missing y-axis vector argument #1505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compas_rhino/conversions/geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def plane_to_rhino(plane):
:rhino:`Rhino.Geometry.Plane`

"""
return Rhino.Geometry.Plane(point_to_rhino(plane[0]), vector_to_rhino(plane[1]))
return Rhino.Geometry.Plane(point_to_rhino(plane[0]), vector_to_rhino(plane[1]), vector_to_rhino(plane[2]))

@tomvanmele tomvanmele Dec 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a COMPAS plane only has a point and a normal (it is not a frame). index 0 will return the base point, and index 1, the normal.

accessing index 2 on a plane object will raise a KeyError.

@tomvanmele tomvanmele Dec 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the redirection to the constructor that uses a point and a normal is correct. i think the functionality you are looking for is frame_to_rhino...

@jwwang0-0 jwwang0-0 Dec 15, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you for the explanation! I'm wrong. That makes sense. I think it would be better to include a data type check in the code to verify whether the input is a compas_plane or a compas_frame. As it stands, it’s a bit confusing, especially since in Rhino plane is defined in a way that’s more similar to a compas_frame.



Comment thread
tomvanmele marked this conversation as resolved.
def frame_to_rhino_plane(frame):
Expand Down
Loading