Merged
Conversation
spirit-at-canva
force-pushed
the
spirit-add-node-depth-limit
branch
2 times, most recently
from
137fc23 to
bfe2c5a
Compare
spirit-at-canva
force-pushed
the
spirit-add-node-depth-limit
branch
from
bfe2c5a to
f8f7684
Compare
Contributor
Author
|
cc @robinst |
spirit-at-canva
commented
Mar 30, 2026
commonmark/src/main/java/org/commonmark/internal/DocumentParser.java
Outdated
Show resolved
Hide resolved
spirit-at-canva
commented
Mar 30, 2026
robinst
reviewed
Mar 30, 2026
Collaborator
robinst
left a comment
robinst
left a comment
There was a problem hiding this comment.
Changes to DocumentParser, Parser, ParserTest LGTM, with some minor comments to address.
The visitor changes: Can you take them out of this PR? I'm not sure I want to include this by default on every visitor, and it's something that's pretty straightforward to add in subclasses (overriding the protected visitChildren method).
commonmark/src/main/java/org/commonmark/node/AbstractVisitor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Robin Stocker <robinst@canva.com>
spirit-at-canva
commented
Mar 31, 2026
Collaborator
|
Released in 0.28.0 now, thanks for the contribution 🎉!: https://github.com/commonmark/commonmark-java/blob/main/CHANGELOG.md#0280---2026-03-31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I want to limit the max depth of node traversal.
What
We apply the limit when constructing the AST, by dropping deeper node generation (we collapse it into plain text).