chore(deps): bump commit-check from 2.17.0 to 2.18.0 - #284
Merged
Merged
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
the
dependencies
dependabot
Bot
added
python
Contributor
Commit Check⊘ All 5 checks skipped — nothing was validated Show all 5 checkscommit-check 2.18.0 · Rules reference |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
Bumps [commit-check](https://github.com/commit-check/commit-check) from 2.17.0 to 2.18.0. - [Release notes](https://github.com/commit-check/commit-check/releases) - [Commits](commit-check/commit-check@v2.17.0...v2.18.0) --- updated-dependencies: - dependency-name: commit-check dependency-version: 2.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
shenxianpeng
force-pushed
the
dependabot/pip/commit-check-2.18.0
branch
from
September 15, 2026 06:56
ae5e2c5 to
33c03b2
Compare
shenxianpeng
added a commit
that referenced
this pull request
Sep 15, 2026
…e checkout's TestRealCommitCheckBinary pipes a message to the real commit-check and asserts the verdict. It ran from this repo's checkout, so the CLI read commit-check.toml -- which inherits the org config over the network -- and, on a runner with no git identity, weighed ignore_authors against the author of HEAD. On a Dependabot PR that author is dependabot[bot], which the org config ignores, so every message check skipped and the test saw "skip" where it asserted "pass" or "fail" (#284, on every OS and Python in the matrix, plus coverage). The same on 2.17.0 and 2.18.0: the bump is not the cause, the test just had never met a bot commit since #279 added it. A piped message describes no commit. Pin everything the verdict was picking up from the surroundings: an explicit, empty --config so no repo or org config applies and ignore_authors names nobody; a known identity at git's global and system levels so the author lookup never falls through to HEAD; and no inherited CCHK_* variable, which would override the file. commit-check's own suite pins the same two lookups for the same reason (its pinned_author fixture); this is that pin from outside the process. No change to main.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps commit-check from 2.17.0 to 2.18.0.
Release notes
Sourced from commit-check's releases.
Commits
26de978docs: update commit-check version to v2.18.0 (#576)ca2f900feat: disclose AI assistance with a trailer, never as a co-author or sign-off...41e5a6dfix: name the setting behind a regex that will not compile (#574)c3f502afix: keep allowed branch types and names as regexes (#573)c423902docs: configuration reference table, contributor docs cleanup, dedupe helpers...d37573ffeat: name what was rejected and by how much when a check fails (#571)2fcb190fix: run the checks under --dry-run, exit 2 and name the file on config error...9d3ce50fix: anchor branch names, exempt only git subjects, report config errors (#569)2d78b99feat: link spec names in errors and shorten long rule suggestions (#568)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)