chore(deps): update dependency dompurify to v3.4.12 [security] - #3279
Open
renovate[bot] wants to merge 1 commit into
Open
chore(deps): update dependency dompurify to v3.4.12 [security]#3279renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.4.9→3.4.12DOMPurify: Permanent
ALLOWED_ATTRpollution viasetConfig()bypassing the hook clone-guard (incomplete fix of the 3.4.7 hook-pollution patch)CVE-2026-65898 / GHSA-cmwh-pvxp-8882
More information
Details
Summary
DOMPurify 3.4.7 shipped a security fix ("permanent hook pollution") that makes a registered
uponSanitizeAttributehook's mutation ofdata.allowedAttributesnon-persistent — so allowing an attribute for one element does not leak into latersanitize()calls. The fix clonesALLOWED_ATTRinside_parseConfig.That guard is silently bypassed whenever the application uses the persistent-config API
DOMPurify.setConfig().setConfig()sets the module flagSET_CONFIG = true, which causessanitize()to skip_parseConfigentirely — and the clone-guard lives inside_parseConfig. The hook is then handed the live, sharedALLOWED_ATTRobject; anydata.allowedAttributes[name] = trueit writes mutates that shared object permanently, for the lifetime of the DOMPurify instance, across every subsequent call, and across all elements.If an application uses
setConfig()together with anuponSanitizeAttributehook that conditionally allows a dangerous attribute (onerror,onclick,onmouseover,srcdoc,formaction, …) for "trusted" elements, then one trusted render permanently allows that attribute on untrusted, attacker-controlled content — yielding stored XSS in viewers' browsers. DOMPurify applies no separate/^on/event-handler blocklist: attribute stripping is governed entirely by the allowlist, so a polluted allowlist is the only gate, and survival in the output is final.Affected configuration (preconditions)
The vulnerability is triggered when an application does both:
DOMPurify.setConfig(...)once (the recommended pattern for a fixed, persistent policy), anduponSanitizeAttributehook that writesdata.allowedAttributes[name] = trueto conditionally allow an attribute (e.g. only for elements bearing a trust marker).This hook pattern is demonstrated in DOMPurify's own test suite, and the per-call variant of exactly this leak is what 3.4.7 was released to fix.
Root cause (source:
src/purify.ts, v3.4.10)The 3.4.7 clone-guard — only inside
_parseConfig:sanitize()skips_parseConfigon the persistent-config path:setConfig()sets the flag that disables the guard:The hook is handed the live allowlist binding, and there is no secondary event-handler defense:
Net: after
setConfig(), the clone-guard never runs, so the hook'sallowedAttributesmutation is a permanent write to the instance's sharedALLOWED_ATTR.Proof of Concept
Environment:
npm i dompurify@3.4.10 jsdom(Node; identical mechanism toisomorphic-dompurify, and to a browser instance).PoC 1 — the leak (trusted render permanently allows
onerroron attacker content)PoC 2 — it is a DOMPurify state-leak, not "the app allowed
on*" (attribute-agnostic)PoC 3 — control: WITHOUT
setConfig()the 3.4.7 guard holdsPersistence (observed)
removeAllHooks()— removing the hook does not clean the polluted allowlist.onmouseoversurvives on<a>and<div>, not only the originally-blessed<img>.clearConfig()does restore a clean state (this is the bound of the impact).Impact
Stored XSS. In a long-lived (e.g. server-side /
isomorphic-dompurify) DOMPurify instance, a single trusted render flips a shared allowlist bit; every subsequent untrusted submission then inherits a live event-handler attribute and executes script in viewers' browsers. Because DOMPurify enforces no/^on/blocklist, a survivingon*attribute is final — no secondary control prevents execution.onerroron a broken-src<img>fires with no user interaction (browser-confirmed; see Validation).Per-call
FORBID_ATTRdoes not mitigate. A defensivesanitize(input, { FORBID_ATTR: ['onerror'] })is also ignored oncesetConfig()has been called: the per-call config is parsed by_parseConfig, whichsanitize()skips entirely underSET_CONFIG. So an application cannot blunt the leak with a per-call denylist — the poisonedALLOWED_ATTRis the sole gate.Realistic attack scenario
A platform mixes admin-authored interactive widgets with user-generated content through one sanitizer instance:
setConfig({ ALLOWED_TAGS: [...], ALLOWED_ATTR: [...] }).uponSanitizeAttributehook that enables an event handler only for admin-vetted elements markeddata-trusted="1", intending safe rich interactivity — a pattern the 3.4.7 fix was specifically meant to make safe.<img src=x onerror=...>passes sanitization and executes for all viewers.Remediation
Extend the existing clone-guard to the persistent-config (
SET_CONFIG) fast-path: whensanitize()skips_parseConfigbut anuponSanitizeAttributehook is registered, clone the allowlists before the walk so hook mutations cannot persist — the exact analogue of the guard already present in_parseConfig.(Equivalently: in the hook-event builder at line ~2088, hand the hook a shallow clone of
ALLOWED_ATTR/ALLOWED_TAGSwheneverSET_CONFIGis true, mirroring the 3.4.7 intent.)A regression test should reproduce PoC 1 and assert the attacker call returns
<img src="x">. Note the existing 3.4.7 regression test ("unguarded attribute hook does not poison subsequent default-config calls") never exercisessetConfig()— adding asetConfigvariant closes the gap.Application-side mitigation until patched: prefer
data.keepAttr = true(per-element, non-persistent) overdata.allowedAttributes[name] = trueinside hooks; or callDOMPurify.clearConfig()between trust domains; or use separate DOMPurify instances for trusted vs. untrusted content.Limitations
setConfig()and a hook writingdata.allowedAttributes[...]). Not a default-config bypass.clearConfig(), which restores a clean state. The earlier-considered "survivesclearConfig()" claim did not reproduce and is withdrawn.data.keepAttr=true, notallowedAttributes[]." However, the 3.4.7 security fix exists precisely to defend theallowedAttributes[]hook pattern in the per-call path; leaving thesetConfigpath unguarded is an incomplete fix of an acknowledged security issue.Validation
dompurify@3.4.10dist/purify.cjs.js(md5ab0e7b1cde1cbcace0f62b6aac284143) and browserdist/purify.min.js(md5b0985f80fa48e6e7b263f8f6a64b779e) are byte-identical to a freshlynpm pack-ed release — the repro is on the real shipped code. Mechanism identical on 3.4.0, 3.4.9 and 3.4.10.DOMPurify.isValidAttribute('img','onerror','x')flipsfalse → trueafter a single trusted render undersetConfig(), proving the shared attribute gate is poisoned. Leak survivesremoveAllHooks(), is cross-element, persists for the instance lifetime, and is reset only byclearConfig().innerHTMLexecutes the survivingonerror(sentinelwindow.__fired = ["ATTACKER-onerror"];onerrorDOM property is afunction), with no user interaction. The no-setConfigA/B control does not fire — execution is attributable to thesetConfigleak, not a harness artifact.Appendix A — Node PoC (complete, runnable)
Expected output:
Appendix B — Browser PoC (complete; confirms execution)
Observed:
handlers fired: ["alert:XSS:<domain>"]→ RESULT: XSS EXECUTED (no user interaction). The same harness without thesetConfig()line stripsonerrorand does not fire.Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:P/VC:N/VI:N/VA:N/SC:L/SI:L/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
DOMPurify:
CUSTOM_ELEMENT_HANDLINGbypassesafterSanitizeElementsfor allowed custom elements.GHSA-c2j3-45gr-mqc4
More information
Details
Summary
There is a possible hook-policy inconsistency in DOMPurify 3.4.11 involving
CUSTOM_ELEMENT_HANDLING.When a custom element is allowed via
CUSTOM_ELEMENT_HANDLING.tagNameCheck, it appears that the element does not go throughafterSanitizeElementsin the same way as a normal element. As a result, an application that relies onafterSanitizeElementsas a security policy layer to strip sensitive attributes from all elements may see those attributes removed from normal elements but preserved on allowed custom elements.This does not appear to be a direct DOMPurify XSS or a case where DOMPurify directly allows executable payloads. The preserved value is still inert at sanitize time. The issue becomes relevant when the allowed custom element later re-injects that attribute value into an HTML sink such as
innerHTML, creating a second-order XSS gadget.Details
The issue appears to originate from the control flow in
src/purify.ts: line 1672~1691CUSTOM_ELEMENT_HANDLINGis parsed from user configuration atsrc/purify.ts: line 741~748In particular,
tagNameCheck,attributeNameCheck, andallowCustomizedBuiltInElementsare copied into the internalCUSTOM_ELEMENT_HANDLINGobject there.During element sanitization,
_sanitizeElements()checks whether a node is forbidden or not allowlisted atsrc/purify.ts: line 1805~1814If so, it immediately delegates to
_sanitizeDisallowedNode(currentNode, tagName)and returns its boolean result.Inside
_sanitizeDisallowedNode(), the custom-element-specific allow path is implemented atsrc/purify.ts: line 1672~1692If the node is treated as a basic custom element and
CUSTOM_ELEMENT_HANDLING.tagNameCheckmatches, the function returnsfalseimmediately at line 1682 or 1689, meaning “do not remove this node”.That early
return falseis significant because control returns directly to_sanitizeElements()via thereturn _sanitizeDisallowedNode(...)at line 1813. As a result, the later logic in_sanitizeElements()is skipped for that custom element instance, including:src/purify.ts: line 1816~1826src/purify.ts: line 1828~1837afterSanitizeElementshook dispatch atsrc/purify.ts: line 1850~1851.In other words, a normal allowlisted element continues through
_sanitizeElements()and reacheshooks.afterSanitizeElements, but a disallowed-by-default element that is revived by theCUSTOM_ELEMENT_HANDLING.tagNameCheckpath does not. This creates a policy inconsistency: an application that relies onafterSanitizeElementsto remove an attribute from all elements will observe that the policy is applied to normal elements but not to custom elements allowed throughCUSTOM_ELEMENT_HANDLING.In the PoC, the application hook removes
data-biofrom ordinary elements, but the same attribute remains on<x-bio>because the custom-element keep path bypassesafterSanitizeElements. The attribute itself is inert at sanitize time and DOMPurify is not directly allowing executable SVG/HTML through. The security impact appears when the application-defined custom element later reads the preserveddata-biovalue inconnectedCallback()and writes it toinnerHTML, turning the preserved attribute into a second-order XSS gadget.PoC
Reproduced on DOMPurify 3.4.11.
Steps
poc.html.divcontrol losesdata-bio, while the allowed custom element keeps it.connectedCallback()runs, the candidate payload is reinserted into the DOM and executes through the custom element’s own sink.HTML PoC
Expected result
This is output of HTML PoC.
Impact
This does not appear to affect DOMPurify’s default configuration as a direct sanitizer bypass.
The impact is limited to applications that:
CUSTOM_ELEMENT_HANDLING,afterSanitizeElementsas a security policy layer,innerHTMLor another HTML sink.In that situation, the behavior can become a second-order XSS gadget because a security-relevant attribute is removed from normal elements but remains on allowed custom elements.
Possible fixes or mitigations might include
afterSanitizeElementsCUSTOM_ELEMENT_HANDLINGmay not participate in the same post-element hook flow as normal allowlisted elements.Severity
CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:A/VC:N/VI:N/VA:N/SC:L/SI:L/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
cure53/DOMPurify (dompurify)
v3.4.12: DOMPurify 3.4.12Compare Source
v3.4.11: DOMPurify 3.4.11Compare Source
setConfig, thanks @trace37labsnpm auditosv-scannersuppression list as no vulnerable dependencies are left for nowv3.4.10: DOMPurify 3.4.10Compare Source
types.tsSAFE_FOR_TEMPLATESscrubbing into single shared pathtextContentbeforeinnerHTMLnpm run bench) with a--comparemodedemos/folder so every demo runs again, and added a SVG-via-<img>demotest:happydomscripts in the READMEConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.