chore(renovate): hold pnpm at 11.10.0 until deploy --legacy regression is fixed - #1034
Closed
ByronDWall wants to merge 1 commit into
Closed
chore(renovate): hold pnpm at 11.10.0 until deploy --legacy regression is fixed#1034ByronDWall wants to merge 1 commit into
ByronDWall wants to merge 1 commit into
Conversation
…n is fixed pnpm/pnpm#13618 documents a regression, first appearing in pnpm 11.19.0 and still present in 11.20.0 (the current published latest), where `pnpm deploy --legacy` leaves a workspace dependency with peerDependencies as a symlink escaping the deploy directory instead of packing it in. In a typical Docker flow, that symlink dangles inside the image and the app crashes at runtime. The fix landed in pnpm/pnpm#13755 but has not shipped in a published pnpm release yet. This repo does not currently run `pnpm deploy --legacy` in a Docker build, so this is a precautionary hold rather than a response to an observed break here. It mirrors the guard already in place on commercetools/nimbus, disabling any Renovate-proposed pnpm bump until the fix ships upstream, at which point the rule should be removed.
|
Contributor
Author
|
Superseded by a consolidated PR bumping to pnpm 11.17.0 and correcting this rule's version reference. |
ByronDWall
added a commit
that referenced
this pull request
Aug 10, 2026
Bumps the packageManager field to pnpm 11.17.0, which stays below the known bad pnpm deploy legacy regression introduced in 11.19.0/11.20.0 (pnpm/pnpm#13618). Adds a Renovate packageRule disabling pnpm updates until pnpm/pnpm#13755 ships in a release, since that fix is merged but not yet published. Supersedes #1032 and #1034, which targeted an earlier pnpm version and an earlier draft of this hold rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
packageRulesentry to.github/renovate.jsonthat disables Renovate-proposedpnpmversion bumps, holding the current pin atpnpm@11.10.0.Why
pnpm/pnpm#13618 documents a regression in
pnpm deploy --legacy, first appearing in pnpm 11.19.0 and still present in 11.20.0 (the current published latest). A workspace dependency that haspeerDependenciesis left as a symlink escaping the deploy directory instead of being packed into it. In a typical Docker flow (COPY ./deploy .into an image), the symlink dangles inside the container and the app crashes at runtime, not at build time.The fix (pnpm/pnpm#13755) merged upstream but has not shipped in any published pnpm release yet.
This repo does not currently run
pnpm deploy --legacyin a Docker build, so this hold is precautionary rather than a response to an observed break here. It mirrors the guard already in place oncommercetools/nimbus's.github/renovate.json.Follow-up
Remove this rule once a pnpm release ships with the fix from pnpm/pnpm#13755.