You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: stop shipping agent skills in the comark package - #569
Written by an AI agent on behalf of @atinux. @atinux has not reviewed it yet.
comark ships a copy of docs/skills in its npm package (9 files, about 93 kB). Agents don't load skills from node_modules by themselves, and the README and the Installation page tell people to run npx skills add https://comark.dev, which serves docs/skills straight from the docs site. Since #562 the copy also runs in every comark build with rm/cp, which CodeRabbit noted breaks on Windows.
Changes
Remove skills from comark's files. build and prepack go back to plain tsc.
Remove the root skills symlink and its .gitignore entry. The symlink pointed at the gitignored packages/comark/skills, so it was already broken on GitHub.
Bundle snapshot: comark back to 422k (167 files).
AGENTS.md: the release section says skills are served from comark.dev.
Verification
pnpm prepack && pnpm vitest run bundle: 2 tests pass.
npm pack --dry-run --json in packages/comark (scripts enabled): 167 entries, none under skills/.
https://comark.dev/.well-known/skills/index.json lists the comark skill, so npx skills add https://comark.dev is unaffected.
Merging this before the release PR (#564) means 0.9.0 ships without skills/.
ELI5
The comark package carried a copy of instructions for AI coding assistants that those assistants don't read from there. They already get them from the website, so the copy goes away and the package gets smaller.
Summary by CodeRabbit
Distribution
Agent skills are now served from comark.dev and are no longer included in the published npm package.
The published package is smaller, with the bundle changing from 515 KB (176 files) to 422 KB (167 files).
No actionable comments were generated in the recent review.
Walkthrough
The comark package no longer includes or copies agent skills. The release instructions state that skills are served from comark.dev and are not shipped in npm packages. The bundle test snapshot reflects the smaller package.
Changes: Comark package contents
Layer / File(s)
Summary
Package contents and validation packages/comark/package.json, .gitignore, skills, AGENTS.md, test/bundle.test.ts
The published files list and build scripts no longer include or copy skills. The release instructions state that skills are served from comark.dev and are not shipped in npm packages. The skills ignore entry is removed, and the bundle snapshot changes to 422k (167 files).
comarkdown/comark#562: Adds the skill-copy steps that this PR removes, and changes the same release instructions and bundle snapshot.
comarkdown/comark#559: Also changes the expected packed comark output, so the bundle snapshot may need to account for both changes.
Suggested reviewers:arashsheyda
Merge Risk: Minimal · up to 2c7e4
Skills will no longer ship in the npm package; no merge-blocking issue is identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "chore: stop shipping agent skills in the comark package" matches the main change. The PR removes the skills directory from the comark npm package, drops the root skills symlink and its .git…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "chore: stop shipping agent skills in the comark package" matches the main change. The PR removes the skills directory from the comark npm package, drops the root skills symlink and its .gitignore entry, and reverts the build and prepack scripts so they no longer copy docs/skills. The title is specific, concise, and uses a conventional commit prefix.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 936805a3-9702-4bd4-ada8-2d8640a37090
Commits
Reviewing files that changed from the base of the PR and between 439c6f0 and 2c7e498.
Files selected for processing: 5
.gitignore
AGENTS.md
packages/comark/package.json
skills
test/bundle.test.ts
Files with no reviewable changes: 2
skills
.gitignore
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comarkships a copy ofdocs/skillsin its npm package (9 files, about 93 kB). Agents don't load skills fromnode_modulesby themselves, and the README and the Installation page tell people to runnpx skills add https://comark.dev, which servesdocs/skillsstraight from the docs site. Since #562 the copy also runs in everycomarkbuild withrm/cp, which CodeRabbit noted breaks on Windows.Changes
skillsfromcomark'sfiles.buildandprepackgo back to plaintsc.skillssymlink and its.gitignoreentry. The symlink pointed at the gitignoredpackages/comark/skills, so it was already broken on GitHub.comarkback to422k (167 files).Verification
pnpm prepack && pnpm vitest run bundle: 2 tests pass.npm pack --dry-run --jsoninpackages/comark(scripts enabled): 167 entries, none underskills/.https://comark.dev/.well-known/skills/index.jsonlists thecomarkskill, sonpx skills add https://comark.devis unaffected.Merging this before the release PR (#564) means 0.9.0 ships without
skills/.ELI5
The comark package carried a copy of instructions for AI coding assistants that those assistants don't read from there. They already get them from the website, so the copy goes away and the package gets smaller.
Summary by CodeRabbit