DRYD-1978: Increase contrast for disabled mini buttons#23
Open
mikejritter wants to merge 1 commit intocollectionspace:mainfrom
Open
DRYD-1978: Increase contrast for disabled mini buttons#23mikejritter wants to merge 1 commit intocollectionspace:mainfrom
mikejritter wants to merge 1 commit intocollectionspace:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Changes the contrast for disabled MiniButton elements
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1978
This fixes an accessibility violation in the pager and other components of cspace-ui. By using the existing
textDark, we should see a contrast ratio of ~7.How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
None.
Has the application documentation been updated for these changes?
n/a
Did someone actually run this code to verify it works?
@mikejritter tested against a local CollectionSpace