v1.2.0 - #53
Merged
Merged
v1.2.0#53
Conversation
…ll commandbox-boxlang
…oading coldbox correctly
Contributor
|
@jclausen tests are failing on BoxLang FYI. |
…vation (#57) * fix: don't rely on request.MODULE_NAME in test harness module activation ColdBox's BaseTestCase clears/bypasses the request scope between virtual-app reinits, so request.MODULE_NAME (set only in Application.cfc's pseudo-constructor) can be gone by the time cbLoadInterceptorHelpers fires on a reinit. This threw a GLOBAL BUNDLE EXCEPTION during the LocalDiskSpec reinit in CI, leaving the cbfs module never re-registered and cascading into "Instance not found: DiskService@cbfs" across almost every remaining spec/engine. Hardcode the module name instead, matching the literal Application.cfc already uses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MY8vKDaEubRApVMT9BXSYk * fix: use current S3Mock env var to seed the initial test bucket adobe/s3mock renamed initialBuckets to COM_ADOBE_TESTING_S3MOCK_STORE_INITIAL_BUCKETS (deprecated in S3Mock 4.5.0, removed thereafter). Pulling the image unpinned meant CI silently stopped creating the cbfs-test bucket, so every S3 disk test failed immediately with "NoSuchBucket" regardless of any application code. Pin the image and use the current env var name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MY8vKDaEubRApVMT9BXSYk * fix: add missing semicolon in RamProvider cleanDirectory closure Fixes the cfformat check failure introduced by the recent cleanDirectory() arrow-function refactor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MY8vKDaEubRApVMT9BXSYk * style: apply cfformat to RamProvider.cfc Ran the project's own cfformat tool (matching CI's format:check step) to fix the method-chain wrapping the previous semicolon fix didn't address. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MY8vKDaEubRApVMT9BXSYk --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boxlang compat