Repository navigation
ci: run typecheck, build and the test suite on pull requests - #2861
Closed
LuisAlbertoMK wants to merge 1 commit into
Closed
LuisAlbertoMK wants to merge 1 commit into
LuisAlbertoMK wants to merge 1 commit into
Conversation
Author
|
Closing this. #267 already settled it — a checked-in CI workflow is a maintainer call, and the answer was no. I should have read that before opening; sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No workflow runs the suite today, so a change is green only on the machine that wrote it. This adds the three steps a contributor runs by hand:
npx tsc --noEmitnpm run build— the CLI and both vitest projects read fromdist/, andbuildalso asserts the viewer bundle and the 29 copied grammarsnpx vitest run --project engine --project ui— explicit, so the log names the project that failed instead of hiding a viewer regression inside an engine failureChoices, all easy to change
pull_request+workflow_dispatch, nopushtomain: it spends no runner time on merges, and a release is triggered by hand anyway. Addingpush: branches: [main]is one line if you want post-merge coverage.node:sqlite, which the database layer requires. A 20/24 matrix is possible but roughly triples the run for coverage the suite does not currently vary on.cache: npmrelies on the committed lockfile.dist/is what says which.Signal
These three steps already ran green on a Linux runner over a tree containing
upstream/mainat428b3c48— typecheck, build, full suite, 11m12s. So this lands with a known-good result rather than a red first run.Happy to trim any of it, or split the workflow from the artifact step if you would rather review them separately.