[colbymchenry]

Summary

In JavaScript and TypeScript, a function declared inside another function now takes the calls made to its name inside that function, even when the file also imports that name from a package:

import { scan } from 'rolldown/experimental';
export async function scanImports() {
  async function scan() { /* … */ }
  const result = scan();   // this file's nested scan(), not rolldown's
}

On main such a call linked to nothing.

Root cause

When a bare call's name is imported from outside the repository, matchByExactName returned no edge at all (the early return added for #2101), since the call means the package's function and no project symbol of that name. A declaration of the name in an inner scope of the calling file shadows the import, but the early return skipped it too.

The fix (from the contributor)

For such a call, the candidates are narrowed to the calling file's own declarations that sit inside a function or method (innerScopeShadows), instead of giving up. A top-level declaration is the import's own binding (var request = require('supertest')), not a shadow. The lexical-reachability rule already in the candidate filter (#1230) then keeps only a declaration that is in scope where the call is.

What we changed on top

• Tests for the scope boundary. The triage worried that innerScopeShadows accepts a declaration nested in any function of the file, not only one around the call. It does, but the reachability rule later in the same filter drops one that isn't in scope. Two new cases pin that down, and both pass on main and here: a call in a sibling function next to function a() { function resolve() {} }, and one in outer() beside a resolve nested a level deeper in mid(). A third case checks the positive side: a call from a function nested inside the declaring one links to the declaration. It fails on main.
• CHANGELOG: the bullet moved next to the JS/TS import bullets, with credit.

Validation

• Tests: out-of-repo-import-shadow.test.ts fails 2 of 6 on main (the two shadowing cases) and passes 6 of 6 here.
• A/B against main (kernel per arm, graph dumps by natural keys): flask (Python), gin (Go), excalidraw, codegraph, pixijs, pdf.js and three.js are byte-identical. vite gains 1 edge, which is right: packages/vite/src/node/optimizer/scan.ts imports scan from rolldown/experimental and declares async function scan() inside scanImports, and the call const result = scan() in scanImports now links to that nested function.
  The A/B was run against main 9c4794d and re-checked against main with fix(js,ts): a call on an element of a class field reaches the element's type #2852 in it (449eefa): vite again gains that one edge, and excalidraw is still identical. The tests fail 2 of 6 on today's main 0d46dba too.
• Cost: index CPU time on codegraph, whose test files are full of bare calls to vitest's imported expect/it, is within noise: 81.7 s → 81.9 s (median of 3, interleaved).
• Suite (CODEGRAPH_KERNEL_EXPECT=1 npx vitest run --maxWorkers=4 --minWorkers=1, on this commit): 759 files, 9,048 tests, 8,966 passed, 0 failed, 82 skipped.

Lands #1715 by @danusha2345.

🤖 Generated with Claude Code