Skip to content

test(explore): a held run shorter than the dedup threshold may come back inside the block around it (#2756) #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danusha2345 wants to merge 1 commit into from
Closed

test(explore): a held run shorter than the dedup threshold may come back inside the block around it (#2756) #2758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions __tests__/explore-cross-call-dedup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,23 @@ describe('a second call against a real index', () => {
// the pointer names it.
expect(second).toContain(POINTER);
for (const [file, lines] of before) {
const repeated = [...(after.get(file) ?? [])].filter((n) => lines.has(n));
const repeated = [...(after.get(file) ?? [])].filter((n) => lines.has(n)).sort((a, b) => a - b);
if (repeated.length === 0) continue;
// The only sanctioned repeat is the anti-abandonment restore, which fires
// ONLY when the call found nothing new to say — and this one did.
throw new Error(`call 2 re-sent ${file} lines ${repeated.slice(0, 5).join(',')}`);
// Two sanctioned repeats. The anti-abandonment restore fires ONLY when
// the call found nothing new to say — and this one did. And rule 3 of
// the range algebra: a held run shorter than MIN_COVERED_LINES is
// re-sent inside the block around it rather than replaced by a pointer
// (the 7-line `RunResult` struct of cycle.go, held by call 1, comes back
// whole inside call 2's render of the file's head — #2756). Any longer
// run is a duplicate.
const runs: number[][] = [];
for (const n of repeated) {
const run = runs[runs.length - 1];
if (run && n === run[run.length - 1]! + 1) run.push(n);
else runs.push([n]);
}
const long = runs.find((run) => run.length >= EXPLORE_DEDUP.MIN_COVERED_LINES);
if (long) throw new Error(`call 2 re-sent ${file} lines ${long.slice(0, 5).join(',')}`);
}
}, 120_000);

Expand Down