[colbymchenry]

Go keeps an unexported name inside its package, yet prometheus tsdb's []*memSeries in head_append.go linked to nothing. The cause is a tie, settled by a veto:

• Name matching scored head.go's memSeries and tsdb/agent's the same. Directory proximity counts shared leading directories, capped at 80 points, so a child package (or, in a deep tree, a sibling package) ties with the package's own directory.
• The first candidate met, tsdb/agent's, then failed the visibility check, and the reference ended unresolved.
• Parameters, results, struct fields, composite literals and calls all failed this way. Examples: prometheus's memSeries and its 1,185 sample{…} literals; kubernetes's simpleCache, pruner, client-go's per-version informer types (deploymentInformer{…} in apps/v1 against apps/v1beta1) and many test helpers.

Follow-up 1 from #2655, which found these failing from struct fields.

Fix

• A Go candidate the reference cannot see is out of the pool before the ranking. matchByExactName already does this for C#, Java, PHP and Scala ("a visible namesake wins where the veto after it would drop the ref"). The rule is isGoNameVisible, now shared with isVisibleAcrossFiles' Go branch: an exported name is visible from anywhere, an unexported one only in its own directory.
• A bare Go call or function value that the surrounding function binds itself is left unresolved. gateTargetKind checks isGoLocallyBound, which wraps the resolver's existing Go block-scope reader goLocalDecl.

Why the second rule is needed

• With only the first rule, names with more namesakes than the ambiguity ceiling started resolving to their package's declaration, which is mostly right.
• But it also exposed bare calls to a local closure named like a package function. Kubernetes had 80 of these new wrong links, for example client-go's init := func(t *testing.T) {…} then init(t) bound to func init(), which Go never lets a program name.
• Go's scoping says a parameter or local shadows every declaration of its package from the end of its declaration on, so the gate applies at the seam every strategy passes through.
• It also removes links that were wrong on main:
  • a test's var ( volumeSpec = volumeSpec(…) ) passed on later (the call inside the declaration keeps its link: the local isn't in scope there yet);
  • a loop's var ( transformer storagevalue.PrefixTransformer … );
  • a local errors map in kubernetes' e2e upgrade tests that linked to kubectl's errors method.

Validation

Before/after full indexes on main a944ec3, diffed per reference site.

repo	added	each judged	dropped	each judged	metadata-only
gin	0	—	0	—	4
etcd	2	own-package calls	25	locally bound	1,356
prometheus	1,251	1,185 sample{…} + 55 refs (memSeries …) + 9 calls, own package; 2 method calls, right method	112	locally bound	1,996
kubernetes	670	543 calls + 120 literals + 4 refs, own package; 3 method calls, right method	542	locally bound	42,017

• Added links: every bare name lands in its own package. The 5 calls written through a value are correct: db.Head().getOrCreate(…) is Head's own method, and ….cache.set(…) goes through envelopeTransformer's field cache *simpleCache to simpleCache.set.
• Dropped links: an independent text check confirmed the local binding (a parameter, :=, var, range variable) for 646 of the 679. I read the remaining 19 kubernetes sites by hand; all are grouped var ( … ) declarations the text check doesn't model.
• Metadata-only: the same edge to the same target, at exact-match confidence 0.9 instead of 0.7 (a few at framework 0.8 before), because the pool now holds only the package's own declaration. Nothing downstream changes: the viewer folds only edges below 0.6.
• codegraph_explore on before/after indexes (8 flow queries on prometheus, 5 on kubernetes): kubernetes is byte-identical; prometheus renders the same symbols, with text-only differences on 6 queries.
• The change is resolver-only, so the kernel binary is unchanged.

Tests

• New __tests__/go-unexported-namesake.test.ts: an indexed module under kernel and wasm, LF and CRLF, with prometheus's shape (namesakes in tsdb/agent and tsdb/chunks). It covers:
  • a parameter, a result, a composite literal and a call reaching the package's own declarations;
  • a struct's fields;
  • the child package keeping its own;
  • a name only another package declares linking to nothing;
  • a local closure and a local init shadowing the package's newSeries and func init().
    Of its 20 tests, 12 fail on main; the 8 that pass are the controls.
• Full suite on a944ec3 + this change (--maxWorkers=4 --minWorkers=1, kernel expected): 7,396 passed, 0 failed, 80 skipped. After merging fix(ts): a call on a known class goes through that class's own bases #2656, which also edits name-matcher.ts, the overlapping files were rerun: this test, ts-known-class-methods, resolution, cross-file-visibility, function-ref, go-struct-field-refs and go-type-position-kinds, 360 tests, all passing.

🤖 Generated with Claude Code