Skip to content

fix(jupiter): cap slippageBps to 0-10000 like the 0x provider - #1393

Open
SashaMIT wants to merge 1 commit into
coinbase:mainfrom
SashaMIT:fix/jupiter-slippage-bps-cap
Open

fix(jupiter): cap slippageBps to 0-10000 like the 0x provider#1393
SashaMIT wants to merge 1 commit into
coinbase:mainfrom
SashaMIT:fix/jupiter-slippage-bps-cap

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Aug 4, 2026

Copy link
Copy Markdown

Description

Jupiter SwapTokenSchema previously accepted any positive integer for slippageBps (no upper bound). The 0x action provider already constrains slippage to 0–10000. This aligns Jupiter with that cap so an agent/tool cannot request unbounded slippage via schema validation.

Note: this does not address blind signing of the remote VersionedTransaction itself; that needs separate quote/tx binding checks.

AI disclosure

Drafted with AI assistance.

Test plan

  • Existing Jupiter tests still pass with default/50 bps
  • Schema rejects values > 10000
  • CI on this PR

Made with Cursor

Prevent agent/tooling from requesting unbounded slippage on Jupiter swaps.
@SashaMIT
SashaMIT requested a review from murrlincoln as a code owner August 4, 2026 09:32
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@github-actions github-actions Bot added action provider New action provider typescript labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants