fix(jupiter): cap slippageBps to 0-10000 like the 0x provider - #1393
Open
SashaMIT wants to merge 1 commit into
Open
fix(jupiter): cap slippageBps to 0-10000 like the 0x provider#1393SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Prevent agent/tooling from requesting unbounded slippage on Jupiter swaps.
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jupiter
SwapTokenSchemapreviously accepted any positive integer forslippageBps(no upper bound). The 0x action provider already constrains slippage to0–10000. This aligns Jupiter with that cap so an agent/tool cannot request unbounded slippage via schema validation.Note: this does not address blind signing of the remote
VersionedTransactionitself; that needs separate quote/tx binding checks.AI disclosure
Drafted with AI assistance.
Test plan
> 10000Made with Cursor