Skip to content

General close reason fixes and improvements - #2158

Merged
ArtOfCode- merged 6 commits into
developfrom
0valt/close-reasons-fixes
Sep 12, 2026
Merged

General close reason fixes and improvements#2158
ArtOfCode- merged 6 commits into
developfrom
0valt/close-reasons-fixes

Conversation

@Oaphi

@Oaphi Oaphi commented Sep 11, 2026

Copy link
Copy Markdown
Member

This PR is primarily concerned with properly scoping close reasons for non-global admins.

Additional minor changes:

  • ostruct is now an explicit dependency. No functional changes, just fixes the warning spam that'll eventually turn into an error:

    /code/config/initializers/config.rb:1: warning: ostruct was loaded from the standard library
    , but will no longer be part of the default gems starting from Ruby 3.5.0.
    You can add ostruct to your Gemfile or gemspec to silence this warning.

  • allows abilities to be updated network-wide even if their descriptions differ - the original restriction breaks multi-community tests. The original restriction was put there by me when implementing the feature out of caution - at this point I am sure it's safe to remove it.
  • identical_post_spam no longer triggers on posts seeded by the system user;

@Oaphi
Oaphi requested review from a team and ArtOfCode- September 11, 2026 23:10
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.40%. Comparing base (9e3f230) to head (1d9e6b6).

Additional details and impacted files
Components Coverage Δ
controllers 77.07% <100.00%> (+0.01%) ⬆️
helpers 85.47% <ø> (ø)
jobs 79.93% <ø> (ø)
models 93.50% <100.00%> (+0.02%) ⬆️
tasks 61.11% <ø> (ø)
scripts ∅ <ø> (∅)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi
Oaphi marked this pull request as draft September 11, 2026 23:42
@Oaphi
Oaphi marked this pull request as ready for review September 12, 2026 00:10
@ArtOfCode-
ArtOfCode- merged commit 0494377 into develop Sep 12, 2026
14 checks passed
@ArtOfCode-
ArtOfCode- deleted the 0valt/close-reasons-fixes branch September 12, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants