Skip to content

Fix scheduled jobs#2001

Merged
Oaphi merged 11 commits intodevelopfrom
art/jobs-again
Mar 3, 2026
Merged

Fix scheduled jobs#2001
Oaphi merged 11 commits intodevelopfrom
art/jobs-again

Conversation

@ArtOfCode-
Copy link
Member

Changes our scripts to use perform_now instead of perform_later so that jobs actually run. Also removes a few old one-time maintenance scripts that are no longer required, and moves a couple of old scripts to jobs instead.

@ArtOfCode- ArtOfCode- requested a review from Oaphi March 2, 2026 16:27
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 40.74074% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.75%. Comparing base (84435d4) to head (833786a).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
app/jobs/recalc_abilities_job.rb 32.25% 21 Missing ⚠️
app/jobs/mail_uncaptured_donations_job.rb 50.00% 11 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
controllers 75.82% <ø> (+0.25%) ⬆️
helpers 85.08% <ø> (ø)
jobs 66.88% <40.74%> (-14.31%) ⬇️
models 93.03% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

class MailUncapturedDonationsJob < ApplicationJob
queue_as :default

def perform(*_args)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: I don't think we need to parametrize it all, do we? We don't use the param anyway, so let's avoid creating mental overhead for those less familiar with the syntax.

Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - low-ish coverage is fine here as there are (a) no changes in how the jobs function, only in how they are executed (+ some of the scripts are wrapped into proper jobs) and (b) it's due to low initial coverage for jobs in general.

@Oaphi Oaphi merged commit 40b9dea into develop Mar 3, 2026
12 of 13 checks passed
@Oaphi Oaphi deleted the art/jobs-again branch March 3, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants