fix - #90
Merged
Merged
fix#90
Conversation
Claude Code aborts a tool call that sends neither a response nor a progress notification for 5 minutes; SSE keepalive comments don't count, so agent_delegate waiting on a peer failed after 300s. The gateway now sends notifications/progress for the call's progressToken instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the
agent_delegateabort after 300s, and the fix holds up against the real Claude Code CLI: a 40-second tool call now completes where it used to be cut off.Cause: Claude Code stops any MCP tool call that sends neither a result nor a progress update for 5 minutes. While
agent_delegatewaited for another agent, the Godmode gateway only sent blank "keepalive" lines every 15s. Those keep the connection open, but Claude Code doesn't count them as progress, so long delegations were cut off. The same applied todelegation_statuswithwait: true.Fix (
packages/core/src/mcp/http.ts): when Claude Code's request includes a progress ID (it always does), the gateway now sends a progress update every 15s ("Still working (Ns)"). Clients that don't send a progress ID still get the old keepalive lines. Waiting up totimeoutSeconds(max 3600) now works.Tests
packages/core/test/mcp.test.ts: a slow delegation gets numbered progress updates with the caller's ID, then the agent's answer. All 40 MCP tests pass and typecheck is clean.sent no response or progress for 30s; aborting— the same error as in this ticket.I merged the latest
maininto the branch before committing (8146344, author ••••••••). Nothing was pushed.What you need to do: after merging, reinstall the desktop app with the update script — the fix lives in the Godmode server inside the app, so the error keeps happening until then.
Task #14 · done by Godmode with Godmode Bot