Repository navigation
tailscale for runner - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "Add a runner" you can now choose how the other Mac reaches this one, and Tailscale is one of the choices. With Tailscale selected, the install command downloads and pairs over the Tailscale IP, so the two Macs don't need to share a home network. Typecheck passes, the 91 runner tests pass (two new ones included), and I tried the dialog on a dev build.
Why it didn't work before: your Tailscale address was already passed along, but the "Install from this Mac" command always downloaded from the first local IP (
192.168.68.56in your screenshot). A Mac reachable only over Tailscale therefore couldn't run it.What changed:
en0).bridge100), for a runner in one of your macOS VMs.100.112.147.65/mbpvd-n.tailb8ef5.ts.net.codext.de).What you should check:
curl -fsS http://100.x.x.x:….godmode/12-tailscale-for-runner.mainhasn't changed since the branch started, so there are no conflicts.Files are in
/Users/danielehrhardt/.godmode/agents/godmode/workspace/task-12/:add-runner-same-network.pngadd-runner-tailscale.pngadd-runner-tailscale-waiting.pngTask #12 · done by Godmode with Godmode Bot