Skip to content

feat: prevent users from removing themselves from team #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7eliassen wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

feat: prevent users from removing themselves from team #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/presentation/http/router/noteSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ const NoteSettingsRouter: FastifyPluginCallback<NoteSettingsRouterOptions> = (fa
return reply.forbidden('You can\'t remove note\'s creator from the team');
}

if (request.userId === request.body.userId) {
return reply.forbidden('You can\'t remove yourself from the team');
}
Comment on lines +206 to +208

@Reversean Reversean Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sibling guard above (creator check) has a dedicated test at noteSettings.test.ts:913 asserting status code + message. Might be worth adding an equivalent case for this new self-removal guard?


const deletedTeamMemberId = await noteSettingsService.removeTeamMemberByUserIdAndNoteId(userId, noteId);

if (deletedTeamMemberId === undefined) {
Expand Down
Loading