refactor: reduce payload size for homepage request#303
Open
7eliassen wants to merge 2 commits into
Open
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Reversean
requested changes
Jul 17, 2026
Comment on lines
+34
to
+49
| export function defineNoteListItem(note: Note): NotePublic { | ||
| const trimmedContent: NoteContent = { | ||
| blocks: note.content.blocks.slice(0, 1), | ||
| }; | ||
|
|
||
| const notePublic: NotePublic = { | ||
| id: note.publicId, | ||
| content: trimmedContent, | ||
| createdAt: note.createdAt, | ||
| updatedAt: note.updatedAt, | ||
| creatorId: note.creatorId, | ||
| cover: note.cover, | ||
| }; | ||
|
|
||
| return notePublic; | ||
| } |
Member
There was a problem hiding this comment.
No test currently asserts that content is trimmed to a single block for the list endpoints.
Could you please add one in noteList.test.ts so the trimming behavior doesn't regress silently?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when the homepage loads, the frontend receives the full data for all notes — including their content. This content is not used at all, yet it increase the transferred payload to several megabytes. As a result, the user experiences a noticeable delay before the note list appears, since the UI waits for the entire response to be received.
Solution
Limit the transmitted data to only the necessary fields. The
contentfield now contains only the note header (first block) instead of the full body, significantly reducing response size and improving load time.