Skip to content

fix: update current input after click (#3045) #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prachi24599 wants to merge 2 commits into
base: next
Choose a base branch
from
+10 −1
Open

fix: update current input after click (#3045) #3052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9023e8e
fix: update current input after click
Prachi24599 Nov 14, 2026
49a3a9b
Merge branch 'next' into fix-list-backspace-cursor
Prachi24599 Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/block/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ export default class Block extends EventsDispatcher<BlockEvents> {
* Bind synchronously so deferred initialization cannot rebind after destroy.
*/
this.holder.addEventListener('change', this.handleSelectChange);
this.holder.addEventListener('click', this.handleClick);

/**
* Bind block events in RIC for optimizing of constructing process time
Expand Down Expand Up @@ -687,6 +688,7 @@ export default class Block extends EventsDispatcher<BlockEvents> {
*/
public destroy(): void {
this.holder.removeEventListener('change', this.handleSelectChange);
this.holder.removeEventListener('click', this.handleClick);
this.unwatchBlockMutations();
this.removeInputEvents();

Expand Down Expand Up @@ -836,7 +838,14 @@ export default class Block extends EventsDispatcher<BlockEvents> {
*/
this.updateCurrentInput();
};


/**
* Update current input after the browser has moved the selection.
*/
private handleClick = (): void => {
this.dropInputsCache();
this.updateCurrentInput();
};
/**
* Handles change events from native select elements.
*
Expand Down