Conversation
Sion612
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
September 23, 2026 14:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saver.save()currently logs caught errors without rethrowing them,allowing a failed save to resolve with
undefined.Rethrow the original error after logging so callers can handle the rejection.
Normal invalid-block filtering and the existing Tune error-handling behavior
remain unchanged.
Add regression coverage for synchronous
Tool.save()throws, asynchronousrejections, invalid-block filtering, and the existing rejection when saving
in read-only mode.
Fixes #3030.
Verification
Local validation of the reviewed candidate:
4 passing / 2 expected failures because save resolved with
undefined.multi-block data preservation, validation rejection, existing Tune behavior,
and awaited read-only transitions.
Existing warnings were retained.
Full Cypress, Firefox, Edge, and a standalone TypeScript check were not run.
The separate review probes are validation evidence and are not included
in this PR.
This change does not implement automatic rollback of the read-only state
after a failed transition.
Implementation and local verification were AI-assisted.