Repository navigation
Handle file links as file references - #2517
Merged
Merged
Conversation
Treat files linked from text and link buttons as referenced, so the usage counts shown when selecting files for bulk deletion include downloads the entry still needs. Include these links in reference-based file rights as well.
Determine which files active references in the configurations of an entry point at, including nested files like text tracks, so the published seed can mark referenced files without shipping reference locations and the walking algorithm.
Render an isReferenced flag for files in the seed of published entries when file rights are derived from references. Only take sections and content elements into account that the seed contains, so hidden and cut off sections do not contribute.
Maintain an index of file references that only rescans the section or content element whose configuration changed. Mark files with an is_referenced attribute and sync it to the preview's entry state, so the preview can tell referenced files apart without walking all configurations on every change. Serve configuration places from the same index.
Let file rights rely on the isReferenced flag provided by the published seed and the editor instead of walking all configurations in the frontend. Only render file reference locations in the editor's seed, since published entries no longer need them. Look up locations of content element types on demand instead of limiting them to the types an entry uses.
The entry schema used the camel cased name of entry state, since file references used to be collected from entry state items. Now that the editor and the server read the entry directly, use the attribute name both of them see.
Name links in tooltip texts and tooltip links as places of file references and activate the area that holds them on select, so editors can find downloads they are about to delete.
Name links in captions of gallery items as places of file references and switch the gallery to the item that holds them on select.
Name links in item texts and item links of external link lists as places of file references and select the item that holds them on select.
Name links in text blocks by their text as places of file references and select the block that holds them on select.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.