Conversation
mmesiti
reviewed
Mar 9, 2026
|
|
||
| with this line so that Sphinx can parse Markdown files: | ||
| ```python | ||
| extensions = ['myst_parser'] |
Collaborator
There was a problem hiding this comment.
Not a strong opinion, but the content of conf.py created by sphinx-quickstart (8.2.3) use single quotes, so it's a little weird to change this here.
mmesiti
reviewed
Mar 9, 2026
mmesiti
reviewed
Mar 9, 2026
mmesiti
reviewed
Mar 9, 2026
mmesiti
reviewed
Mar 9, 2026
mmesiti
reviewed
Mar 9, 2026
Collaborator
|
Please consider my suggestions, but do not feel obliged to accept the ones that look mostly opinion-based. One could add a couple of sentences about the advantages and disadvantages of using text-based notebook formats, but maybe this can become its own issue that we can postpone for the moment. |
Co-authored-by: Michele Mesiti <mmesiti@users.noreply.github.com>
frankier
force-pushed
the
add-myst-nb-exercise
branch
from
7a3ae1b to
b6fe1c8
Compare
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also adds some cleanups to the other Sphinx exercises