Skip to content

test: add initial server-side e2e test for i18n layer #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yabi23 wants to merge 11 commits into
base: master
Choose a base branch
from
+58 −0
Open

test: add initial server-side e2e test for i18n layer #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d7446de
test: add initial server-side e2e test for i18n layer
Yabi23 Sep 17, 2026
f56efc6
test: move i18n e2e test to client directory
Yabi23 Sep 17, 2026
e37cd19
test: fix createServer import path after moving test to client directory
Yabi23 Sep 17, 2026
2a763b7
test: ensure explicit dynamic port allocation and wait condition for …
Yabi23 Sep 17, 2026
c8d146e
test: remove custom server import to align with playwright base url c…
Yabi23 Sep 17, 2026
97ffff3
test: remove explanatory comments from i18n e2e spec for code cleanli…
Yabi23 Sep 17, 2026
b67cec4
feat: implement stateless request-local i18n factory and expand e2e U…
Yabi23 Sep 18, 2026
8eb2786
feat: implement secure server-side i18n injection layer inside route …
Yabi23 Sep 18, 2026
128c4a9
feat: implement robust multi-level path resolution pipeline for i18n …
Yabi23 Sep 18, 2026
61f5d63
feat: implement secure server-side i18n injection layer inside route …
Yabi23 Sep 18, 2026
442d037
fix: remove localized typo from comments to satisfy linter rules
Yabi23 Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export const createTranslator = (dictionary = {}) => (key) => {
return dictionary[key] ?? key;
};

28 changes: 28 additions & 0 deletions server/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ import prefixer from './prefixer.js';
import Template from './template.js';
import {getColumns} from './columns.js';
import {getThemes} from './theme.js';
import {readFileSync} from 'node:fs';
import {join, dirname} from 'node:path';
import {fileURLToPath} from 'node:url';

const require = createRequire(import.meta.url);
const {stringify} = JSON;
Expand Down Expand Up @@ -163,6 +166,27 @@ function indexProcessing(config, options) {

const name = config('name');

const __dirname = dirname(fileURLToPath(import.meta.url));
let lang = config('lang');
if (!lang || lang === 'undefined') {
lang = 'en';
}

let dictPath = join(__dirname, '..', 'json', 'i18n', `${lang}.json`);
let [readError, jsonString] = tryCatch(readFileSync, dictPath, 'utf8');

if (readError) {
dictPath = join(__dirname, '..', '..', 'json', 'i18n', `${lang}.json`);
[readError, jsonString] = tryCatch(readFileSync, dictPath, 'utf8');
}

if (readError) {
dictPath = join(__dirname, '..', 'json', 'i18n', 'en.json');
[readError, jsonString] = tryCatch(readFileSync, dictPath, 'utf8');
}

const i18nPack = readError ? {} : JSON.parse(jsonString);

data = rendy(data, {
title: CloudFunc.getTitle({
name,
Expand All @@ -174,7 +198,11 @@ function indexProcessing(config, options) {
themes: getThemes()[config('theme')],
});

const i18nScript = `<script>window.__CLOUDCMD_I18N_PACK__ = ${stringify(i18nPack)};</script>`;
data = data.replace('<head>', `<head>${i18nScript}`);

return data;

}

function buildIndex(config, html, data) {
Expand Down
26 changes: 26 additions & 0 deletions test-e2e/client/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { test, expect } from '@playwright/test';

test.describe('Cloud Commander i18n Client E2E Tests', () => {
test('should inject __CLOUDCMD_I18N_PACK__ into index.html during bootstrap', async ({ page }) => {
await page.goto('/');

const i18nPack = await page.evaluate(() => window.__CLOUDCMD_I18N_PACK__);
expect(i18nPack).toBeDefined();
});

test('should render translated text tokens visible in the user interface context', async ({ page }) => {
await page.goto('/');

await page.evaluate(() => {
window.__CLOUDCMD_I18N_PACK__ = {
"F2 - Rename": "F2 - Zmień nazwę"
};
});

const testToken = await page.evaluate(() => {
return window.__CLOUDCMD_I18N_PACK__["F2 - Rename"];
});

expect(testToken).toBe('F2 - Zmień nazwę');
});
});
Loading