This repository was archived by the owner on Nov 18, 2026. It is now read-only.
Repository navigation
fix: reject leading dashes in worktree branch names - #269
Open
harjotgill wants to merge 1 commit into
Open
harjotgill wants to merge 1 commit into
harjotgill wants to merge 1 commit into
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A branch name entered at the interactive prompt can reach Git as an option. The command can then report success for a worktree that did not check out the requested branch. Reject leading dashes during the shared worktree name validation, before fetching, creating a branch, or creating a worktree. This also covers PR checkout and explicit folder overrides.
The new CLI regression reproduces the false success on the v3.1.0 source and passes with the fix. It checks that rejected input leaves the worktree registry and destination untouched. Seven existing cases passed across ordinary creation, branch tracking, literal branch names, and native/fallback PR checkout. ShellCheck on
lib/core.shandgit diff --checkpassed.Summary by CodeRabbit
newcommand now rejects prompted branch names beginning with-and reports an error, preventing unintended worktree changes.