feat: compile-time fallback include path#98
Merged
asharkhan3101 merged 4 commits intocoder3101:mainfrom Dec 3, 2025
Merged
Conversation
Owner
|
I like the idea overall. Could you also document this change in README, env variable is fine whatever the nix systems use. |
coder3101
reviewed
Dec 2, 2025
Contributor
Author
Thanks, I'll update the README. As for the variable, there is no particular name in nix, I'll provide there whatever we settle upon in protols. |
komar007
force-pushed
the
fallback_include_path
branch
from
6d73d2d to
27c6f44
Compare
komar007
commented
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a result of a small investigation into how to make protols work out of the box with the well-known protobuf types, even though it does not ship them. See NixOS/nixpkgs#465302.
The idea is to be able to configure, in compile time, a lowest-priority include path that a distro package could set to make sure, without compromising other sources of include paths, that protols can find the well-known types even when
pkg-configandprotobufare missing from the environment and no paths have been manually configured via CLI or settings.Please advise on the best name for the environment variable.