Skip to content

🤖 feat: complete the Mux to Xum rename - #3928

Open
matifali wants to merge 21 commits into
mainfrom
rename-all-mux-mnentions-to-xum-the-project-was
Open

🤖 feat: complete the Mux to Xum rename#3928
matifali wants to merge 21 commits into
mainfrom
rename-all-mux-mnentions-to-xum-the-project-was

Conversation

@matifali

Copy link
Copy Markdown
Member

Summary

Complete the remaining Mux → Xum rename across the desktop app, internal TypeScript API, persisted storage, branding assets, VS Code integration, documentation, developer tooling, and Terminal-Bench harness.

What changed

  • Make ~/.xum and Electron userData/xum canonical while retaining centralized .mux / .cmux migration, read fallback, and downgrade aliases.
  • Harden migration rollback so data returns to the actual legacy source if compatibility alias creation fails, and align pre-startup home discovery with migration behavior.
  • Rename project-owned Mux* message, provider, ACP, Gateway/Governor, SSH, and mDNS symbols to Xum* while preserving serialized and wire-level compatibility values.
  • Replace the Mux-derived icon geometry with a distinct four-ribbon Xum mark and regenerate desktop, tray, favicon, PWA, docs, and VS Code assets.
  • Make xum canonical in Make targets, logs, service-worker caches, workflows, benchmarks, docs, fixtures, and visible UI; retain explicit compatibility aliases where existing consumers depend on them.
  • Add make check-xum-branding, backed by a reviewed compatibility allowlist, plus non-writing icon freshness/dimension/content validation.

Compatibility contracts retained

  • com.mux.app installer identity and mux:// deep links.
  • mux CLI/npm forwarding package and mux-* release artifacts.
  • .mux, .cmux, .muxignore, and MUX_* fallback/alias behavior.
  • VS Code Marketplace/package IDs and persisted mux.* command/settings keys.
  • Serialized/wire/provider/discovery values including muxMetadata, X-Mux-Workspace-Id, mux-gateway, and _mux-api._tcp.
  • External endpoints that still use established Mux identities, such as mux.coder.com and ghcr.io/coder/mux.

Validation

  • make check-xum-branding
  • bun scripts/generate-icons.ts check
  • make fmt-check
  • make lint
  • make typecheck
  • Focused compatibility/path/product/protocol/log suites: 93 passed, 5 skipped
  • Xum transition suite: 28 passed, 5 skipped
  • Terminal-Bench adapter suite: 24 passed
  • Trust CLI suite: 5 passed

The full source suite was also exercised: 11,843 passed, 14 skipped, with unrelated environment/global-isolation failures in existing backup/Git, timing, browser, and filesystem tests.


Generated with xum • Model: openai:gpt-5.6-sol • Thinking: high

Replace the reused x-and-cursor icon with a compact four-part convergence
mark, regenerate every tracked square branding asset, and add a non-writing
freshness and image-validity check to the canonical generator.

Validation:
- bun scripts/generate-icons.ts update
- bun scripts/generate-icons.ts check
- make build-icons
- make typecheck
- make fmt-check
- make lint
Make Xum canonical for the Make CLI, Terminal-Bench harness, service-worker cache, local logs, and shared developer environment while preserving explicit legacy aliases and environment inputs.

Add a scoped, Make-backed branding audit with behavioral coverage for stale copy and filenames.
@mintlify

mintlify Bot commented Aug 22, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Mux 🟢 Ready View Preview Aug 22, 2026, 8:56 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@matifali

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5043ef444

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/terminal-bench.yml
Comment thread benchmarks/terminal_bench/prepare_leaderboard_submission.py Outdated
Comment thread benchmarks/terminal_bench/xum_agent.py Outdated
@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please take another look at the latest commit.

@matifali

Copy link
Copy Markdown
Member Author

Addressed all Codex findings in c93dcda:

  • Updated both BigQuery uploaders to prefer XUM_EXPERIMENTS / XUM_RUN_AS_GOAL by key presence with MUX_* fallback.
  • Excluded both canonical and pre-rename app/token artifacts from leaderboard submissions.
  • Made empty canonical benchmark env values explicitly clear legacy aliases and added regression coverage.

Validation: make fmt-check, make lint-actions, make check-bench-agent, uploader precedence checks, and Python compilation.

@codex review

@matifali

Copy link
Copy Markdown
Member Author

Follow-up: the required legacy leaderboard artifact exclusions are now covered by a narrow, documented branding-audit allow rule with regression coverage. make static-check-full passes locally.

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please retry the review; the previous attempt returned an unknown error.

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74edb2682d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/common/types/message.ts
@matifali

Copy link
Copy Markdown
Member Author

Addressed the public package compatibility finding in e199f37 by retaining MuxMessage as a documented alias of canonical XumMessage.

Validated with root typecheck/message suites and the separately published @coder/mux-chat-components package typecheck + production build.

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e199f37f99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchmarks/terminal_bench/xum_agent.py Outdated
@matifali

Copy link
Copy Markdown
Member Author

Addressed the providers-file precedence finding: compatibility env lookups now share one presence-based resolver, so an explicitly empty XUM_PROVIDERS_FILE suppresses a stale MUX_PROVIDERS_FILE. Added regression coverage and validated the branch behavior plus benchmark agent checks.

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cac1f7504

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchmarks/terminal_bench/xum_agent.py Outdated
@matifali

Copy link
Copy Markdown
Member Author

Addressed the agent-plugin branding finding:

  • Renamed user-visible installer/registry/lock/cleanup/update errors from Mux to Xum.
  • Canonicalized plugin installer path comments to ~/.xum.
  • Added the production installer to the branding-audit boundary and retained only the stable .mux-promotion-marker compatibility literal.
  • Added regression coverage and updated affected installer expectations.

Validation: focused installer expectations, typecheck, branding audit, formatting, and make static-check-full.

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please provide the final regular code review for commit 4e4d1f60e. All findings are resolved, current main is merged, the PR is conflict-free, and required CI is green.

@matifali

Copy link
Copy Markdown
Member Author

The failed sendModeDropdown integration case passed locally under TEST_INTEGRATION=1 ... --runInBand; rerunning the failed CI job as a flake. No code change required.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please provide the final regular code review for current head 4e4d1f60e. All review findings are resolved, current main is merged, the PR is conflict-free, and required CI is green.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please run the final regular code review for current head 4e4d1f60e. The security review is complete, every code-review thread is resolved, current main is merged, and the branch is conflict-free.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please run the regular code review for the current conflict-free head 4e4d1f60e. All review threads are resolved and all required CI checks pass.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please perform the regular code review for current conflict-free head 4e4d1f60e. Security review is already complete; all code-review findings are resolved and required CI is green.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

Merged the latest main commit (ec3a4b71b, ChatPane edit-cancel scroll fix) without conflicts. Typecheck and make static-check-full pass.

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 248d978703

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/audit_xum_branding.py
Comment thread benchmarks/terminal_bench/analyze_failure_rates.py Outdated
@matifali

Copy link
Copy Markdown
Member Author

Addressed both latest Codex findings:

  • Added plugin sourceInput.ts to the branding audit and changed malformed-input examples to coder/xum.
  • Preserved stable mux_fail_rate / mux_agent JSON keys alongside canonical xum_* keys, with regression coverage.

Validation: source-input tests, JSON compatibility test, branding audit tests, typecheck, and make static-check-full.

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please provide the final regular code review for current conflict-free head 3d2a3b52d. All findings are resolved, current main is merged, and local validation is green.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review
Please perform the final regular code review for current head 3d2a3b52d. All code-review findings are resolved, current main is fully merged, the branch is conflict-free, and required CI passes.

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@matifali

Copy link
Copy Markdown
Member Author

Conflict resolution is complete and the branch contains current main. All required CI checks pass and every code-review thread is resolved.

Codex has repeatedly returned only the optional security review instead of a new regular review for the current head despite explicit @codex review requests. Pausing further duplicate retries because they are not producing a different result; human guidance may be needed if a fresh current-head Codex approval is required.

@chatgpt-codex-connector

Copy link
Copy Markdown

Summary

  • No code changes were needed. Conflict resolution is complete, current main is included, required CI passes, and all review threads are resolved.
  • Pausing further duplicate @codex review requests because they repeatedly produce only optional security reviews. Human guidance is needed if a fresh regular approval for current head 3d2a3b52d remains mandatory.
  • No commit or new pull request was created because the working tree is clean.

Testing

  • git status --porcelain=v1
  • git log -1 --oneline — current head is 3d2a3b5 fix: preserve plugin and benchmark rename compatibility

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant