Repository navigation
fix(workspace): keep the last startup log line from wrapping - #1150
Merged
Merged
Conversation
Show Logs writes the logs when the terminal opens, before it has its final width, so lines wrap at a narrow width. xterm.js rejoins wrapped lines when the terminal widens, except the line with the cursor. The last log line had no line break, so it held the cursor and stayed wrapped or cut off. End every line with a line break.
jeremyruppel
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show Logs on the startup script warning (#1129) opens one terminal per failed script. The last log line in each terminal came out wrapped at a narrow width or cut off.
Cause
The pseudoterminal writes all the logs in
open, before the terminal has its final width, so long lines wrap at a narrow width. When the panel widens, xterm.js rejoins wrapped lines, except the block that holds the cursor (reflowLargerGetLinesToRemoveskips it unlessreflowCursorLineis set). The logs were joined with\r\nand the last line had no line break after it, so the cursor stayed on the last log line and that line never rejoined.Fix
End every line with
\r\n, as the ping terminal incliExec.tsalready does. The cursor then sits on an empty line below the logs, so every log line can rejoin.Validation
pnpm typecheck,pnpm lint, andpnpm format:checkpass.The warning is unreleased, so this needs no changelog entry.