DNM: chore!: use map over list for template tf_vars & provisioner_tags#124
Draft
ethanndickson wants to merge 1 commit intomainfrom
Draft
DNM: chore!: use map over list for template tf_vars & provisioner_tags#124ethanndickson wants to merge 1 commit intomainfrom
ethanndickson wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson
changed the title
ethanndickson
force-pushed
the
ethan/attr-map-change
branch
from
e9fd608 to
5ab89ee
Compare
ethanndickson
force-pushed
the
ethan/attr-map-change
branch
from
5ab89ee to
1128eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge this PR until we're ready for a 1.0 release.
Closes #121.
For reference, seeing how poor the plan output is when modifying a list of
tf_varswas what convinced me this was a worthwhile QOL change. That would drive me nuts if I was working with a bunch of them.