Enable Devcontainer-cli module to block user login until script finishes running

[justmanuel]

Description

Allow for devcontainer-cli module to prevent users from logging in until its finished running.

Type of Change

• New module
• New template
• Bug fix
• [x ] Feature/enhancement
• Documentation
• Other

Module Information

Path: registry/coder/modules/devcontainers-cli
New version: 1.1.0
Breaking change: [ ] Yes [x ] No

Testing & Validation

• Tests pass (bun test)
• Code formatted (bun fmt)
• [ x] Changes tested locally

Related Issues

None

[DevelopmentCats]

Overall this looks good.

I don't think you would need to declare start_blocks_login as false in every test considering it defaults to false.

You would also want to update the version for this following the versioning guidelines in CONTRIBUTING.md.

[DevelopmentCats]

@justmanuel LGTM I will test it and make sure this doesn't cause any wonky behavior. Also you might need to run bun fmt for the ci to pass.

Thanks for the contribution!

[justmanuel]

@justmanuel LGTM I will test it and make sure this doesn't cause any wonky behavior. Also you might need to run bun fmt for the ci to pass.

Thanks for the contribution!

Yeah sorry thought I had ran that.

[DanielleMaywood]

@DevelopmentCats I'm happy with the changes from my side, will leave the final approval up to you

[DevelopmentCats]

@justmanuel

I have tested and everything looks good to me too.

I will just need you to update the version in the README for this module following the CONTRIBUTING.md versioning guidelines.

[justmanuel]

@justmanuel

I have tested and everything looks good to me too.

I will just need you to update the version in the README for this module following the CONTRIBUTING.md versioning guidelines.

Hi @DevelopmentCats , I;m a bit confused I thought I had updated it according to the CONTRIBUTING.md, if I am adding a variable should the new version not be 1.1.0 ? or are we talking about it needing to be updated in a different README?

[DevelopmentCats]

@justmanuel
I have tested and everything looks good to me too.
I will just need you to update the version in the README for this module following the CONTRIBUTING.md versioning guidelines.

Hi @DevelopmentCats , I;m a bit confused I thought I had updated it according to the CONTRIBUTING.md, if I am adding a variable should the new version not be 1.1.0 ? or are we talking about it needing to be updated in a different README?

Nah you are right I was just missing the last part of the diff..

My bad!

We are good to go here then I will run the CI once more, and release. Thanks for the work!! ❤️