feat: add mcp_config input variable to vscode-desktop-core module#753
Open
phorcys420 wants to merge 6 commits intomainfrom
Open
feat: add mcp_config input variable to vscode-desktop-core module#753phorcys420 wants to merge 6 commits intomainfrom
mcp_config input variable to vscode-desktop-core module#753phorcys420 wants to merge 6 commits intomainfrom
Conversation
9 tasks
phorcys420
commented
Feb 24, 2026
| description = "The URI protocol the IDE." | ||
| } | ||
|
|
||
| variable "config_folder" { |
Member
Author
There was a problem hiding this comment.
maybe config_dir is better
phorcys420
commented
Feb 24, 2026
Member
Author
|
see an example on how this works with the cursor module in my other PR: |
phorcys420
commented
Feb 24, 2026
phorcys420
commented
Feb 24, 2026
matifali
reviewed
Feb 25, 2026
| description = "The URI protocol the IDE." | ||
| } | ||
|
|
||
| variable "config_folder" { |
DevelopmentCats
requested changes
Feb 25, 2026
Contributor
DevelopmentCats
left a comment
DevelopmentCats
left a comment
There was a problem hiding this comment.
Aside from the comments above everything else looks good to me!
You will need to bump the versions in the README for this module though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardizes handling of
mcpvariables in VSCode Desktop-based modules.Made modular enough to pave the way for setting other config files than
mcp_server.jsonandmcp.json.Type of Change
Testing & Validation
bun test)bun fmt)