🤖 refactor: replace sections with sub-project hierarchy#3143
Open
ammar-agent wants to merge 3 commits intomainfrom
Open
🤖 refactor: replace sections with sub-project hierarchy#3143ammar-agent wants to merge 3 commits intomainfrom
ammar-agent wants to merge 3 commits intomainfrom
Conversation
Replace project sections with path-inferred sub-project nesting, drop section-specific creation and routing state, and layer AGENTS instructions from parent to child directories. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `n/a`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=n/a -->
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba1fdba5bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Update Storybook interaction stories to stop relying on the removed section selector and to avoid ambiguous text assertions in immersive review coverage. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `n/a`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=n/a -->
Collaborator
Author
|
@codex review |
Preserve workspace-first instruction loading for local single-project workspaces while still layering parent-to-child AGENTS directories for nested sub-projects. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `n/a`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=n/a -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces project sections with path-inferred sub-projects, simplifies workspace creation and routing to be project-only, and layers AGENTS instructions from parent to child directories so nested sub-projects inherit repo guidance naturally.
Background
Sections were metadata-only UI groupings that duplicated filesystem structure and required section-specific creation, draft, and routing state. The requested direction was to treat sub-projects as real sub-folders instead, infer hierarchy from paths, and ignore legacy section data.
Implementation
Validation
make static-checkbun test src/node/services/systemMessage.test.ts src/browser/utils/ui/workspaceFiltering.test.ts src/browser/features/ChatInput/useCreationWorkspace.test.ts src/browser/components/ProjectPage/ProjectPage.autofocus.test.tsx src/browser/contexts/RouterContext.test.tsxmake test-unitstill fails in unrelated pre-existing areas (e.g. WorktreeArchiveSnapshotService, hooks timing tests, AppLoader, PinnedTodoList, BrowserBridgeServer)Risks
The highest regression risk is in sidebar project rendering and AGENTS instruction assembly for nested projects, since both now depend on inferred path ancestry instead of explicit section metadata.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:n/a