🤖 fix: prevent open-time transcript layout flash#3140
Open
ammar-agent wants to merge 1 commit intomainfrom
Open
🤖 fix: prevent open-time transcript layout flash#3140ammar-agent wants to merge 1 commit intomainfrom
ammar-agent wants to merge 1 commit intomainfrom
Conversation
Keep ChatPane's synchronous transcript bottom-pinning effect in sync when hydration-gated transcript chrome appears without changing the latest message. Add a regression test covering the older-history button path on cached transcript open. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$6.19`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=6.19 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the chat transcript from flashing when opening a non-streaming workspace whose cached history reveals additional transcript chrome without appending a new latest message.
Background
The transcript already had a synchronous bottom-pinning path for send-time footer changes, but opening cached history could still reveal UI like the older-history button after hydration finished. Because that transition does not change
latestMessageId, the transcript could paint one frame at the old scroll position before the async auto-scroll path corrected it.Implementation
Validation
bun test ./tests/ui/chat/bottomLayoutShift.test.tsmake static-checkRisks
Low. The change only expands when the existing auto-scroll-owned bottom-pinning layout effect runs, and the regression test covers the newly-fixed open-time path.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$6.19