Fix build args #463
Open
Fix build args #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hext-dev
added a commit
to hext-dev/envbuilder
that referenced
this pull request
Jan 14, 2026
This commit improves the code quality of twsl's ARG parsing fix by extracting the duplicated logic into a reusable helper function. Changes: - Add buildArgsWithDefaults() helper that merges external build args with ARG defaults from a Dockerfile, respecting precedence rules - Refactor UserFromDockerfile() to use the new helper - Refactor ImageFromDockerfile() to use the new helper and simplify the FROM instruction finding logic - Remove debug fmt.Println statements from tests The original fix (PR coder#463) correctly addressed issue coder#455 where build args from devcontainer.json were not being used when resolving image references in Dockerfiles with ARG variables. This refactoring reduces code duplication while preserving the fix's behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have any go skills whatsoever, but here is my attempt to fix #455