Repository navigation
🤖 fix: bump Go to 1.26.9 and golang.org/x/net to v0.60.0 - #222
Merged
Merged
Conversation
Change-Id: Ida8dc1d7426a799be39516b0eaa6ef4bd19855a7 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2026
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221
Summary
Bump the Go toolchain from 1.26.8 to 1.26.9 and
golang.org/x/netfrom v0.58.0 to v0.60.0. This clears the 12 called vulnerabilities that makego tool govulncheck ./...(the last step of the requiredlintjob) fail, and the HIGH findings that fail the Trivy filesystem and image scans.Background
Since the vulnerability database update after 2026-10-03, every new CI run fails
lint,Trivy filesystem scanandTrivy image scan, so no PR can merge (#163 included).Advisories fixed (all were reported as called by coder-k8s code):
yieldas regexp preceder keywordImplementation
go.mod:go 1.26.9. CI, CodeQL and release read the toolchain throughsetup-gogo-version-file: go.mod, so no workflow change is needed.Dockerfile.goreleasercopies a prebuilt binary into distroless and pins no Go version.flake.nixuses the unpinned nixpkgsgoand is not used by CI, so I left it andflake.lockunchanged.go get golang.org/x/net@v0.60.0, thengo mod tidy && go mod vendor. Minimal version selection also raised the x/net requirements:x/cryptov0.57.0,x/modv0.41.0,x/syncv0.23.0,x/sysv0.48.0,x/termv0.46.0,x/textv0.42.0.vendor/is regenerated, not hand-edited.Validation
GOFLAGS=-mod=vendor go tool govulncheck ./...(the exact CI command, govulncheck v1.1.4 built and run with go1.26.9, DB updated 2026-10-08): before, 12 called vulnerabilities on go1.26.8 (the list above). After:Your code is affected by 0 vulnerabilities, exit 0. The one remaining module-level entry is GO-2026-5932 (unmaintainedx/crypto/openpgp, not called, no fix exists).fs --skip-dirs vendoron agit archiveof the head reports 0 forgo.mod. ACGO_ENABLED=0go1.26.9 build of the binary reports 0 for thegobinarytarget.make verify-vendor,make build,make lint,make test,make test-integration,make docs-checkpass locally.make vulnfails on my host only because its PATHgovulncheckwas built with go1.25 ("package requires newer Go version go1.26"); CI does not use that binary.Risks
Low. This is a patch-level toolchain bump plus patch/minor bumps of
golang.org/xmodules. No coder-k8s code changes. The full Kind E2E in CI covers the runtime paths.Generated with
mux• Model:anthropic:claude-opus-5-5• Thinking:high