Repository navigation
🤖 docs: name the manager-role binding as the source of CA key access - #170
Merged
Merged
Conversation
The standalone row of the CA key table said that coder-k8s can read the key if its ServiceAccount exists. The access comes from the manager-role ClusterRoleBinding, not from the ServiceAccount alone. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I568eb7f6e5364e908c5c44696be6cbd1223df855
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct one cell in the CA key table of
docs/how-to/deploy-aggregated-apiserver.md. The standalone row said "If thecoder-k8sServiceAccount exists in the cluster,coder-k8scan also read the key." It now says "Ifcoder-k8sis installed with itsmanager-rolebinding,coder-k8scan also read the key." The text keeps the plain-English style (ASD-STE100, about 80%) of the earlier docs pass.Background
A follow-up from the final assessment of the plain-English docs pass (#168). A ServiceAccount alone gives no access. The read access comes from the RBAC binding:
config/rbac/role.yaml: themanager-roleClusterRole allowsget,list,watch, and other verbs onsecretsin the core API group.config/rbac/clusterrolebinding.yaml: thecoder-k8sClusterRoleBinding bindsmanager-roleto the ServiceAccountcoder-k8sincoder-system.internal/controller/codercontrolplane_controller.go:217: the kubebuilder RBAC marker that generates the Secret rule.Factual fix
docs/how-to/deploy-aggregated-apiserver.md(standalone row of the CA key table): the condition forcoder-k8saccess was the existence of the ServiceAccount. It is now themanager-rolebinding, as described above.Validation
make docs-check(strict mkdocs build),markdownlint-cli20.18.1,cspell8.19.4, andlycheepass on the pushed commit.Refs: no issue. Follow-up to #168.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high