Skip to content

Promote timing tests in internal/aggregated/storage still flake under host load #354

Closed

Description

@ThomasK33

Summary

The promote timing tests in internal/aggregated/storage still flake under host load, after #309 (which fixed #288):

  • TestTemplatePromoteConfirmation/timeout_before_apply
  • TestTemplatePromoteDeadline/...

Both failed together in one make test run on the PR branch for #352, at a host load average of about 50, and passed on the next run of the same head. #352 does not touch that package.

#288's residual note named the elapsed > 1s wall-clock check in TestTemplatePromoteConfirmation as the likely remaining cause.

Fix

Replace the wall-clock checks with the fake clock or a deterministic hook, as #309 did for the PATCH timing. Run the package with -count=20 under load (for example with stress or a parallel go test of another package) to show it holds.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: medium

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions