refactor: use nixos-facter module from nixpkgs instead of flake input - #70
Merged
Conversation
The nixos-facter NixOS module was upstreamed into nixpkgs (nixos/modules/hardware/facter, in module-list.nix) and is imported automatically. It exposes the same hardware.facter.reportPath option the hosts already set, so the nixos-facter-modules flake input is redundant. Drop the input and its module import; the nixos-facter CLI package was already sourced from nixpkgs. Update README/agents.md references.
phorcys420
marked this pull request as ready for review
August 24, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
nixos-facterNixOS module was upstreamed into nixpkgs (nixos/modules/hardware/facter, registered inmodule-list.nix) and is now imported automatically. It exposes the samehardware.facter.reportPathoption our hosts already set, so thenixos-facter-modulesflake input is redundant.This drops the input and its
mkHostmodule import, relying on the nixpkgs-provided module instead. Thenixos-facterCLI package was already sourced from nixpkgs, so it is unchanged.Changes
flake.nix: removenixos-facter-modulesinput, outputs arg, and thenixosModules.facterimport.flake.lock: regenerated (input node removed).README.md/agents.md: update references.Validation
Ran in a
nixos/nixcontainer (nixos-25.11):coder-thinkcentreand all image hosts (_appliance-iso,_appliance-disk,_installer-iso) evaluate to atoplevelderivation, confirminghardware.facter.reportPathstill resolves.make fmt/checkandmake lint(statix / deadnix / shellcheck) pass with 0 changes.Note
The nixpkgs module imports fewer submodules than the flake version did (covers disk, firmware, graphics, keyboard, networking, system, virtualisation; the flake version also had bluetooth, boot, camera, debug, fingerprint).
coder-thinkcentrekeepshardware-configuration.nixas a backstop, so no functional regression there. Worth keeping in mind for any future disko-only host that relies purely on facter.Opened by Coder Agents on behalf of @phorcys420.